Code samples changes related to Meilisearch release (v0.28.0) #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meili-bot
added
documentation
bidoubiwa
force-pushed
the
bump-meilisearch-v0.28.0
branch
from
704f22e to
f46f78d
Compare
|
bidoubiwa
reviewed
Aug 29, 2022
brunoocasali
approved these changes
Aug 29, 2022
.code-samples.meilisearch.yaml
Outdated
| client.index("movies").delete().await.unwrap(); | ||
| get_one_document_1: |- | ||
| let movie: Movie = client.index("movies").get_document(String::from("25684")).await.unwrap(); | ||
| let movie: Movie = client.index("movies").get_document(String::from("25684"), ["id", "title", "poster", "release_date"].to_vec()).await.unwrap(); |
There was a problem hiding this comment.
Why .to_vec() is required here? But not in .with_status(["succeeded", "failed"]) ?
| let key = client.get_key("6062abda-a5aa-4414-ac91-ecd7944c0f8d").await.unwrap(); | ||
| get_all_keys_1: |- | ||
| let keys = client.get_keys().await.unwrap(); | ||
| let mut query = KeysQuery::new().with_limit(3).execute(&client).await.unwrap(); |
There was a problem hiding this comment.
Some of the examples are multiline and some are not, I think it could be nice to follow a standard :)
There was a problem hiding this comment.
If I bring consistency now I have to do it on every sample even the ones that are not linked to this PR.
Maybe an issue that request that change ?
There was a problem hiding this comment.
Perfect for me! You can open the issue :)
Co-authored-by: Bruno Casali <[email protected]>
…arch/meilisearch-rust into meili-bot/code-samples-v0-28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is auto-generated.
Update the code-samples.meilisearch.yml according to the integration-guides issue for more information and the complete description about what should be done here check that issue.