Skip to content

Conversation

@guimachiavelli
Copy link
Member

@guimachiavelli guimachiavelli commented Jun 27, 2022

Closes #1722

Note for reviewers: you may ignore the failed CI checks, as they are currently failing due to a link to a document created in another PR.

@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 27, 2022
@guimachiavelli guimachiavelli changed the base branch from v0.28-pagination-guide to v0.28-pagination June 28, 2022 10:52
@guimachiavelli guimachiavelli marked this pull request as ready for review June 28, 2022 12:04
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change but all good 👾

@guimachiavelli
Copy link
Member Author

PR approved by @meilisearch/docs-team, let's see wait to see what core has to say before merging.

maryamsulemani97 and others added 10 commits June 30, 2022 16:48
1766: v0.28: Add pagination to core concepts/indexes r=guimachiavelli a=maryamsulemani97

Adds the pagination index setting to:
-`learn/core_concepts/indexes.md`
-`learn/configuration/settings.md`

Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@maryamsulemani97
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 5, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants