Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 26, 2022

Pull Request

What does this PR do?

Related to #247
issue: Create More examples

This PR is to help create another example of how to use the meilisearch-rust SDK. I created a simple command line search application showcasing the different fine tuning one can do with meilisearch using the Rust SDK. This is the initial commit for the cli-app

@ghost ghost marked this pull request as ready for review April 27, 2022 13:01
@irevoire irevoire requested review from bidoubiwa and brunoocasali May 2, 2022 22:05
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @salugi 👏 👏

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot ! 🔥

@bidoubiwa bidoubiwa added the enhancement New feature or request label May 5, 2022
@bidoubiwa
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request May 5, 2022
279: initial commit for cli-app example to meilisearch-rust r=bidoubiwa a=salugi

# Pull Request

## What does this PR do?
Related to #247
[issue: Create More examples](#247)

This PR is to help create another example of how to use the meilisearch-rust SDK. I created a simple command line search application showcasing the different fine tuning one can do with meilisearch using the Rust SDK. This is the initial commit for the cli-app 


Co-authored-by: a1 <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 5, 2022

Build failed:

@bidoubiwa
Copy link
Contributor

There is a failing test with main

thread 'client::tests::test_list_all_indexes_raw' panicked at 'called Result::unwrap() on an Err value: ParseError(Error("invalid type: null, expected struct MeilisearchError", line: 1, column: 4))', src/client.rs:936:5

@ghost
Copy link
Author

ghost commented May 5, 2022

Do I have to change something? I'm unsure of what my pull request would affect in the tests
@bidoubiwa

@bidoubiwa
Copy link
Contributor

bidoubiwa commented May 5, 2022

Let's see if it is a flacky test

bors bot added a commit that referenced this pull request May 5, 2022
@bidoubiwa
Copy link
Contributor

bors try

@bors
Copy link
Contributor

bors bot commented May 5, 2022

try

Already running a review

@irevoire
Copy link
Contributor

irevoire commented May 5, 2022

Yeah, @salugi code changed nothing to the lib or the tests. It’s a flaky test 😩

@bidoubiwa
Copy link
Contributor

bors r-

@bors
Copy link
Contributor

bors bot commented May 5, 2022

try

Build succeeded:

@bidoubiwa
Copy link
Contributor

Well! Either flacky or github 🤷‍♀️

@bidoubiwa

This comment was marked as duplicate.

bors bot added a commit that referenced this pull request May 5, 2022
279: initial commit for cli-app example to meilisearch-rust r=bidoubiwa a=salugi

# Pull Request

## What does this PR do?
Related to #247
[issue: Create More examples](#247)

This PR is to help create another example of how to use the meilisearch-rust SDK. I created a simple command line search application showcasing the different fine tuning one can do with meilisearch using the Rust SDK. This is the initial commit for the cli-app 


Co-authored-by: a1 <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 5, 2022

Canceled.

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r-

@bidoubiwa

This comment was marked as duplicate.

bors bot added a commit that referenced this pull request May 5, 2022
279: initial commit for cli-app example to meilisearch-rust r=bidoubiwa a=salugi

# Pull Request

## What does this PR do?
Related to #247
[issue: Create More examples](#247)

This PR is to help create another example of how to use the meilisearch-rust SDK. I created a simple command line search application showcasing the different fine tuning one can do with meilisearch using the Rust SDK. This is the initial commit for the cli-app 


Co-authored-by: a1 <[email protected]>
@bors

This comment was marked as duplicate.

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 5, 2022

Build succeeded:

@bors bors bot merged commit 8be4954 into meilisearch:main May 5, 2022
@curquiza
Copy link
Member

curquiza commented May 5, 2022

Hey @salugi, thanks a lot for your involvement in this repository!
We would love to do a shoutout to the community work on Twitter in the coming weeks!
Do you have a Twitter account? And if yes, would you accept to share it with us? 😇
In private by email if you are not comfortable letting it here. My email is on my GitHub profile.
See you soon 👋

bors bot added a commit that referenced this pull request May 9, 2022
287: Update version for the next release (v0.17.0) r=curquiza a=brunoocasali

This version makes this package compatible with Meilisearch v0.27.0 🎉
Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes.

## ⚠️ Breaking changes

* Remove jsonindex (#278) `@abhizer`

## 🚀 Enhancements

* Add cli-app example to meilisearch-rust (#279) `@salugi`
* Ensure nested field support (#273) `@bidoubiwa`
* Add new search parameters `highlightPreTag`, `highlightPostTag` and `cropMarker` (#274) `@bidoubiwa`
* Add User-Agent header to have analytics in every HTTP request (#254) `@brunoocasali`

Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection)
Also, of course, every analytics data we collect are **ANONYMOUS** [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html).



Thanks again to `@abhizer,` `@bidoubiwa,`  `@irevoire,` `@salugi` and a1! 🎉


Co-authored-by: Bruno Casali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants