Add new search parameters highlightPreTag, highlightPostTag and cropMarker #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
reviewed
May 2, 2022
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub highlight_pre_tag: Option<&'a str>, | ||
| /// Tag after the a highlighted term. | ||
| /// ex: `hello world</ mytag>` |
There was a problem hiding this comment.
Suggestion:
/// Tag after the highlighted term.
/// ex: `hello world</mytag>`
brunoocasali
reviewed
May 2, 2022
| setup_test_index(&client, &index).await?; | ||
|
|
||
| let mut query = Query::new(&index); | ||
| query.with_query("sed do eiusmod"); |
There was a problem hiding this comment.
I like this way of declaring builders :D
let mut query = Query::new(&index)
.with_query("sed do eiusmod")
.with_attributes_to_crop(Selectors::All)
brunoocasali
reviewed
May 2, 2022
| /// Marker at the start and the end of a cropped value. | ||
| /// ex: `...middle of a crop...` | ||
| /// | ||
| /// Default: `...` |
There was a problem hiding this comment.
There is a subtle difference in the … to ...
/// Default: `…`
bors bot
added a commit
that referenced
this pull request
May 9, 2022
287: Update version for the next release (v0.17.0) r=curquiza a=brunoocasali This version makes this package compatible with Meilisearch v0.27.0 🎉 Check out the changelog of [Meilisearch v0.27.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.27.0) for more information on the changes. ##⚠️ Breaking changes * Remove jsonindex (#278) `@abhizer` ## 🚀 Enhancements * Add cli-app example to meilisearch-rust (#279) `@salugi` * Ensure nested field support (#273) `@bidoubiwa` * Add new search parameters `highlightPreTag`, `highlightPostTag` and `cropMarker` (#274) `@bidoubiwa` * Add User-Agent header to have analytics in every HTTP request (#254) `@brunoocasali` Analytics is enabled by default in the server, but you can disable them by following [this guide](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html#how-to-disable-data-collection) Also, of course, every analytics data we collect are **ANONYMOUS** [read the guide for more information](https://docs.meilisearch.com/learn/what_is_meilisearch/telemetry.html). Thanks again to `@abhizer,` `@bidoubiwa,` `@irevoire,` `@salugi` and a1! 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per meilisearch/meilisearch#2214 new search parameters are introduced:
highlightPreTaghighlightPostTagcropMarker