fixed formatting with clippy and removed Document trait #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@irevoire just an FYI based on your comment, you can add people as a co-author of the PR if you want. |
irevoire
force-pushed
the
fix/remove-document-trait
branch
from
fb2fea0 to
1373183
Compare
|
Oh, thank you! I did that 😁 |
irevoire
force-pushed
the
fix/remove-document-trait
branch
from
1373183 to
d96b44e
Compare
kvinwang
reviewed
Apr 21, 2022
Co-authored-by: Adrian Coutsoftides <[email protected]>
irevoire
force-pushed
the
fix/remove-document-trait
branch
from
521ca58 to
154e8b8
Compare
brunoocasali
added
the
breaking-change
.code-samples.meilisearch.yaml
Outdated
| let client = Client::new("http://localhost:7700", "masterKey"); | ||
| #[derive(Serialize, Deserialize, Debug)] | ||
| #[derive(Serialize, Deserialize )] |
| /// ``` | ||
| pub async fn get_settings(&self) -> Result<Settings, Error> { | ||
| Ok(request::<(), Settings>( | ||
| request::<(), Settings>( |
There was a problem hiding this comment.
Can you give me some idea behind this change? Why it was required before and now isn't?
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Apr 22, 2022
267: fixed formatting with clippy and removed Document trait r=brunoocasali a=irevoire # Pull Request Since `@honne23` doesn't seem available currently, and we have #262, #263, and #264 waiting for this PR to be merged, I took back on it. But thanks a lot, `@honne23;` you wrote most of the code, and I just applied the few left comments. Thanks for contributing! ## What does this PR do? Fixes #255 Closes #261 <!-- Please link the issue you're trying to fix with this PR, if none then please create an issue first. --> ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Adrian Coutsoftides <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Apr 25, 2022
272: Update version for the next release (v0.16.0) r=brunoocasali a=brunoocasali ### Release notes: ##⚠️ Breaking changes * Use an `OffsetDateTime` on the `ClientStats` (#244) `@irevoire` * Fixed formatting with clippy & Removed `Document` trait (#267) `@irevoire` ## 🚀 Enhancements * Add methods to automatically add/update documents in batches (#262) `@abhizer` * Feature/Tenant Token (#263, #264) `@brunoocasali` ## Misc * Create an example showing how to update the Settings (#245) `@irevoire` Thanks again to `@abhizer,` `@bidoubiwa,` `@brunoocasali,` `@irevoire,` and Adrian Coutsoftides! 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Since @honne23 doesn't seem available currently, and we have #262, #263, and #264 waiting for this PR to be merged, I took back on it.
But thanks a lot, @honne23; you wrote most of the code, and I just applied the few left comments.
Thanks for contributing!
What does this PR do?
Fixes #255
Closes #261
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!