Feature/Tenant Token #263
Merged
Feature/Tenant Token #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
feature/tenant-token
branch
2 times, most recently
from
6612ff4 to
fc2bc24
Compare
|
For the reviewers: this branch is breaking because I'm waiting for #261 to be merged :) |
irevoire
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Hey @brunoocasali thanks for your PR 😁
I think we should add a test with an api-key containing an utf-8 string with a multi-byte character around the 8th byte just to ensure we don't break our code later.
And maybe also a test that try to get a tenant token from meilisearch to see if we deserialize correctly our date?
irevoire
reviewed
Apr 21, 2022
3 tasks
bors bot
added a commit
that referenced
this pull request
Apr 22, 2022
267: fixed formatting with clippy and removed Document trait r=brunoocasali a=irevoire # Pull Request Since `@honne23` doesn't seem available currently, and we have #262, #263, and #264 waiting for this PR to be merged, I took back on it. But thanks a lot, `@honne23;` you wrote most of the code, and I just applied the few left comments. Thanks for contributing! ## What does this PR do? Fixes #255 Closes #261 <!-- Please link the issue you're trying to fix with this PR, if none then please create an issue first. --> ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Adrian Coutsoftides <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
bors bot
added a commit
that referenced
this pull request
Apr 22, 2022
267: fixed formatting with clippy and removed Document trait r=brunoocasali a=irevoire # Pull Request Since `@honne23` doesn't seem available currently, and we have #262, #263, and #264 waiting for this PR to be merged, I took back on it. But thanks a lot, `@honne23;` you wrote most of the code, and I just applied the few left comments. Thanks for contributing! ## What does this PR do? Fixes #255 Closes #261 <!-- Please link the issue you're trying to fix with this PR, if none then please create an issue first. --> ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Adrian Coutsoftides <[email protected]> Co-authored-by: Bruno Casali <[email protected]>
brunoocasali
force-pushed
the
feature/tenant-token
branch
2 times, most recently
from
0c02f35 to
d4523a2
Compare
brunoocasali
force-pushed
the
bump-meilisearch-v0.26.0
branch
from
e780e28 to
d241a7e
Compare
irevoire
reviewed
Apr 23, 2022
irevoire
suggested changes
Apr 23, 2022
brunoocasali
force-pushed
the
feature/tenant-token
branch
from
d4523a2 to
bc8c3b7
Compare
brunoocasali
force-pushed
the
feature/tenant-token
branch
from
bc8c3b7 to
f3570f2
Compare
bidoubiwa
reviewed
Apr 25, 2022
brunoocasali
force-pushed
the
feature/tenant-token
branch
from
f3570f2 to
f694815
Compare
bors bot
added a commit
that referenced
this pull request
Apr 25, 2022
272: Update version for the next release (v0.16.0) r=brunoocasali a=brunoocasali ### Release notes: ##⚠️ Breaking changes * Use an `OffsetDateTime` on the `ClientStats` (#244) `@irevoire` * Fixed formatting with clippy & Removed `Document` trait (#267) `@irevoire` ## 🚀 Enhancements * Add methods to automatically add/update documents in batches (#262) `@abhizer` * Feature/Tenant Token (#263, #264) `@brunoocasali` ## Misc * Create an example showing how to update the Settings (#245) `@irevoire` Thanks again to `@abhizer,` `@bidoubiwa,` `@brunoocasali,` `@irevoire,` and Adrian Coutsoftides! 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the generate_tenant_token following the specification meilisearch/specifications#89