Bump meilisearch to v0.25.0 - New task API #225

irevoire · 2022-02-03T18:39:19Z

We’ll do a little overview of what changed in this PR.

For the users:

All the update types have been renamed to task
The creation and deletion of index are now asynchronous
The Progress type have been removed entirely.
The method wait_for_pending_update has been replaced by the method wait_for_task which takes a task uid or a task directly in parameter.
A method wait_for_completion has been implemented directly on the Task

For the contributors:

fix Clone for Client #217
Consider using macros #126 has been started with the new MeiliSearch_test macro for the unit tests only: https://github.com/meilisearch/meilisearch-rust/blob/41dd6dc765b7938ac399a12db2576b6ab9d479d1/meilisearch-test-macro/README.md
fix Make each test independent #109
fix Remove indexes after running the tests #29

.github/workflows/tests.yml

Kerollmops

That is an amazing job that you've done here, especially this proc macro 🎉
Thank you very much for the time you took to improve this SDK!

Cargo.toml

README.md

src/client.rs

src/indexes.rs

src/tasks.rs

curquiza · 2022-02-08T15:41:37Z

.github/workflows/tests.yml

      run: cargo build --verbose
    - name: Meilisearch (latest version) setup with Docker
-      run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics=true --master-key=masterKey
+      run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics --master-key=masterKey


Suggested change

run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics --master-key=masterKey

run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics=true --master-key=masterKey

Not yet, will be for v0.26.0, not v0.25.0 :)

I am not sure that I understand that, the previous version of meilisearch works with this change, and the newer version (v0.26) will only work with this change. This patch makes the command line compatible with the future version of Meilisearch and doesn't break the v0.25 one.

Can't we accept this change?

Hum from what I see it has been merged some times ago already; meilisearch/meilisearch#1984
And it works for me on meilisearch v0.25.2

CONTRIBUTING.md

meilisearch-test-macro/README.md

alallema

Thank you so much for this PR @irevoire ❤️
✨ Amazing work ✨
I left a few comments.

Also I didn't see the wait_for_task function in the Index can we do something like:

client.index("indexName").wait_for_task(1);

.github/workflows/tests.yml

README.md

src/client.rs

src/indexes.rs

alallema · 2022-02-08T15:40:49Z

src/search.rs

+        let t1 = index.set_filterable_attributes(["kind", "value"]).await?;
+        let t2 = index.set_sortable_attributes(["title"]).await?;
+
+        t2.wait_for_completion(client, None, None).await?;


I really like this name wait_for_completion 🥇 . You could do an issue to propose this new name 😊

alallema

Awesome 🔥 🔥 🔥
LGTM!

Kerollmops

Could you remove the serialize lines, please? :)

irevoire · 2022-02-08T17:48:30Z

oops yes sorry I thought I clicked on the commit suggestion button my bad.

Update CONTRIBUTING.md Apply code suggestions Co-authored-by: Amélie <[email protected]>

Kerollmops

Looks good to me Tamo! Thank you!

curquiza · 2022-02-08T18:10:30Z

Perfecto!

bors merge

bors · 2022-02-08T18:15:12Z

Build succeeded:

irevoire changed the base branch from main to bump-meilisearch-v0.25.0 February 7, 2022 12:46

irevoire force-pushed the task branch from f0a75e5 to 41dd6dc Compare February 8, 2022 13:36

irevoire marked this pull request as ready for review February 8, 2022 13:37

curquiza requested review from Kerollmops, alallema and brunoocasali February 8, 2022 13:46

irevoire force-pushed the task branch from 41dd6dc to e9d0689 Compare February 8, 2022 13:59

sanders41 reviewed Feb 8, 2022

View reviewed changes

.github/workflows/tests.yml Show resolved Hide resolved

Kerollmops requested changes Feb 8, 2022

View reviewed changes

irevoire force-pushed the task branch from 3350026 to f2c5a36 Compare February 8, 2022 15:34

curquiza requested changes Feb 8, 2022

View reviewed changes

alallema reviewed Feb 8, 2022

View reviewed changes

irevoire force-pushed the task branch from 603f709 to 5f422cf Compare February 8, 2022 17:31

irevoire requested review from Kerollmops, alallema and curquiza February 8, 2022 17:33

irevoire force-pushed the task branch from 5f422cf to 9932e0c Compare February 8, 2022 17:34

curquiza approved these changes Feb 8, 2022

View reviewed changes

curquiza changed the title ~~Bump meilisearch to v0.25.0~~ Bump meilisearch to v0.25.0 - Regarding new task API Feb 8, 2022

curquiza changed the title ~~Bump meilisearch to v0.25.0 - Regarding new task API~~ Bump meilisearch to v0.25.0 - New task API Feb 8, 2022

alallema approved these changes Feb 8, 2022

View reviewed changes

Kerollmops requested changes Feb 8, 2022

View reviewed changes

Update the sdk to meilisearch v0.25.2

cb9085d

Update CONTRIBUTING.md Apply code suggestions Co-authored-by: Amélie <[email protected]>

irevoire force-pushed the task branch from 9932e0c to cb9085d Compare February 8, 2022 17:48

irevoire requested a review from Kerollmops February 8, 2022 17:48

Kerollmops approved these changes Feb 8, 2022

View reviewed changes

bors bot merged commit dd3a0a5 into meilisearch:bump-meilisearch-v0.25.0 Feb 8, 2022

This was referenced Feb 9, 2022

Make each test independent #109

Closed

Remove indexes after running the tests #29

Closed

Clone for Client #217

Closed

Use wait_for_pending_update method instead of sleep #203

Closed

curquiza added the breaking-change The related changes are breaking for the users label Feb 10, 2022

	run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics --master-key=masterKey
	run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics=true --master-key=masterKey

Bump meilisearch to v0.25.0 - New task API #225

Bump meilisearch to v0.25.0 - New task API #225

Uh oh!

Conversation

irevoire commented Feb 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Kerollmops left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

curquiza Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

curquiza Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

Kerollmops Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

irevoire Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alallema left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alallema Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

alallema left a comment

Choose a reason for hiding this comment

Uh oh!

Kerollmops left a comment

Choose a reason for hiding this comment

Uh oh!

irevoire commented Feb 8, 2022

Uh oh!

Kerollmops left a comment

Choose a reason for hiding this comment

Uh oh!

curquiza commented Feb 8, 2022

Uh oh!

bors bot commented Feb 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

irevoire commented Feb 3, 2022 •

edited

Loading