Make each test independent

[curquiza]

To avoid side effects between each test, the tests should all be independent.

It means, at the beginning of each test:

• create the needed index(es)
• push documents according to the test
• update settings if necessary

And at the end of each test:

• remove the index(es)

This is linked to #29

[sanders41]

I have looked into creating and deleting the index with each test and the problem I have run into is because the tests are running in threads, the tests still fail. The reason for this is multiple tests can be running at the same time trying to use the same index name. One solution to this is to run the tests all in a single thread with cargo test -- --test-threads=1. By doing this the tests no longer overlap and will pass, but the test take MUCH longer to run.

Some solutions I can currently think of are:

1. Run all tests in a single thread
   • Advantage: All indexes can have the same name
   • Disadvantage: Slows down the tests
2. Mock all the network calls
   • Advantages:
     • All indexes can have the same name
     • Tests run fast
   • Disadvantage: Since the main purpose of the client is to talk to Meilisearch through the API moving that to mocks seems like a bad idea.
3. Give each index a unique name
   • Advantages:
     • Tests run fast
     • Can still use real network calls
   • Disadvantage:
     • Have to ensure that each index name across all files is unique.
     • Doesn't look as good in docs

[Mubelotix]

@sanders41 I have already thought about this issue. Your third solution has already been applied here and I plan to extend this structure to all other tests. However, there is another issue that you did not expect. For a reason I am unable to explain when tests make simultaneous requests to the MeiliSearch server, requests will hang and never get answers. So we cannot remove test-threads=1 anyway.

[sanders41]

For a reason I am unable to explain when tests make simultaneous requests to the MeiliSearch server, requests will hang and never get answers.

I have seen this issue also. I was guessing it was happening because of the index overlap, but sounds like your testing shows that isn’t the cause.

[irevoire]

Closed by #225