Settings changes #530
Merged
Settings changes #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
requested changes
Jul 28, 2020
There was a problem hiding this comment.
Tests are failing when testing with the v0.13.0rc0.
$ docker run -it --rm -p 7700:7700 getmeili/meilisearch:v0.13.0rc0 ./meilisearch --no-analytics=true --master-key=masterKeyCan you detailed why and, if needed, which PR should be merged before this one for the tests to be fixed? 🙂
curquiza
added
the
breaking-change
This was referenced Jul 28, 2020
Merged
bidoubiwa
added a commit
that referenced
this pull request
Aug 3, 2020
Update compatibility with meilisearch Remove acceptNewFields and update tests accordingly (#530) Remove sys-info and sys-info pretty (#528) Change error message from bad primary key update Change error messages Create simple meilisearch error Add type for meilisearch error Add tests for attributesToRetrieve in getDocuments Add get and post method for search function Disable eslint warning remove console.log Search method can only accept array of string on bigamous fields Add extra tests to check if typescrypts generics work correctly Update node example Remove undefined from object before sending search Make batches to tests different test methods Update types
bidoubiwa
added a commit
that referenced
this pull request
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in the CI will fail until MeiliSearch
v0.13.0is out.Currently, tested with the
v0.13.0rc0, tests are failing because of:genre: 'fantasy'missing in search tests, fixed in: Post search route #529404on get system info tests: fixed in Remove sys-info and sys-info pretty #528