Remove acceptNewFields and update tests accordingly (#530)

meilisearch · Jul 28, 2020 · 57e5c52 · 57e5c52
1 parent 7872423
commit 57e5c52
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 205 deletions.
diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml
@@ -84,8 +84,7 @@ update_settings_1: |-
       synonyms: {
           'wolverine': ['xmen', 'logan'],
           'logan': ['wolverine']
-      },
-      acceptNewFields: false
+      }
   })
 reset_settings_1: |-
   client.getIndex('movies').resetSettings()
@@ -148,10 +147,6 @@ update_displayed_attributes_1: |-
   ])
 reset_displayed_attributes_1: |-
   client.getIndex('movies').resetDisplayedAttributes()
-get_accept_new_fields_1: |-
-  client.getIndex('movies').getAcceptNewFields()
-update_accept_new_fields_1: |-
-  client.getIndex('movies').updateAcceptNewFields(false)
 get_index_stats_1: |-
   client.getIndex('movies').getStats()
 get_indexes_stats_1: |-
@@ -295,10 +290,6 @@ settings_guide_displayed_1: |-
       'rank'
     ]
   })
-settings_guide_accept_new_fields_1: |-
-  client.getIndex('movies').settings({
-    acceptNewFields: false
-  })
 add_movies_json_1: |-
   const movies = require('./movies.json')
   index.addDocuments(movies).then((res) => console.log(res))

diff --git a/README.md b/README.md
@@ -474,14 +474,6 @@ If you want to know more about the development workflow or want to contribute, p
 - Reset Displayed Attributes
   `index.resetDisplayedAttributes(): Promise<EnqueuedUpdate>`
 
-### Accept new fields <!-- omit in toc -->
-
-- Get Accept new fields
-  `index.getAcceptNewFields(): Promise<boolean>`
-
-- Update Accept new fields
-  `index.updateAcceptNewFields(acceptNewFields: boolean): Promise<EnqueuedUpdate>`
-
 ### Keys <!-- omit in toc -->
 
 - Get keys

diff --git a/src/index.ts b/src/index.ts
@@ -598,34 +598,6 @@ class Index<T> extends MeiliAxiosWrapper implements Types.IndexInterface<T> {
 
     return await this.delete(url)
   }
-
-  ///
-  /// ACCEPT NEW FIELDS
-  ///
-
-  /**
-   * Get the accept-new-fields value.
-   * @memberof Index
-   * @method getAcceptNewFields
-   */
-  async getAcceptNewFields(): Promise<boolean> {
-    const url = `/indexes/${this.uid}/settings/accept-new-fields`
-
-    return await this.get(url)
-  }
-
-  /**
-   * Update the accept-new-fields value.
-   * @memberof Index
-   * @method updateAcceptNewFields
-   */
-  async updateAcceptNewFields(
-    acceptNewFields: boolean
-  ): Promise<Types.EnqueuedUpdate> {
-    const url = `/indexes/${this.uid}/settings/accept-new-fields`
-
-    return await this.post(url, acceptNewFields)
-  }
 }
 
 export { Index }
diff --git a/src/types.ts b/src/types.ts
@@ -163,7 +163,6 @@ export interface Settings {
   synonyms?: {
     [field: string]: string[]
   }
-  acceptNewFields?: boolean
 }
 
 /*
@@ -344,8 +343,6 @@ export interface IndexInterface<T = any> extends MeiliAxiosWrapperInterface {
     displayedAttributes: string[]
   ) => Promise<EnqueuedUpdate>
   resetDisplayedAttributes: () => Promise<EnqueuedUpdate>
-  getAcceptNewFields: () => Promise<boolean>
-  updateAcceptNewFields: (acceptNewFields: boolean) => Promise<EnqueuedUpdate>
 }
 
 export interface MeiliAxiosWrapperInterface {

diff --git a/tests/accept_new_fields_tests.ts b/tests/accept_new_fields_tests.ts
diff --git a/tests/displayed_attributes_tests.ts b/tests/displayed_attributes_tests.ts
@@ -50,7 +50,7 @@ describe.each([
       .getIndex(index.uid)
       .getDisplayedAttributes()
       .then((response: string[]) => {
-        expect(response.sort()).toEqual(Object.keys(dataset[0]).sort())
+        expect(response).toEqual(['*'])
       })
   })
   test(`${permission} key: Update displayed attributes`, async () => {
@@ -83,7 +83,7 @@ describe.each([
       .getIndex(index.uid)
       .getDisplayedAttributes()
       .then((response: string[]) => {
-        expect(response.sort()).toEqual(Object.keys(dataset[0]).sort())
+        expect(response).toEqual(['*'])
       })
   })
 })

diff --git a/tests/get_or_create_tests.ts b/tests/get_or_create_tests.ts
@@ -51,9 +51,9 @@ describe.each([{ client: publicClient, permission: 'Public' }])(
   'Test on getOrCreateIndex',
   ({ client, permission }) => {
     test(`${permission} key: try to getOrCreateIndex and be denied`, async () => {
-      await expect(
-        client.getIndex(index.uid).getAcceptNewFields()
-      ).rejects.toThrowError(`Invalid API key: ${PUBLIC_KEY}`)
+      await expect(client.getOrCreateIndex(index.uid)).rejects.toThrowError(
+        `Invalid API key: ${PUBLIC_KEY}`
+      )
     })
   }
 )
@@ -62,9 +62,9 @@ describe.each([{ client: anonymousClient, permission: 'No' }])(
   'Test on getOrCreateIndex',
   ({ client, permission }) => {
     test(`${permission} key: try to getOrCreateIndex and be denied`, async () => {
-      await expect(
-        client.getIndex(index.uid).getAcceptNewFields()
-      ).rejects.toThrowError(`You must have an authorization token`)
+      await expect(client.getOrCreateIndex(index.uid)).rejects.toThrowError(
+        `You must have an authorization token`
+      )
     })
   }
 )
diff --git a/tests/searchable_attributes_tests.ts b/tests/searchable_attributes_tests.ts
@@ -50,7 +50,7 @@ describe.each([
       .getIndex(index.uid)
       .getSearchableAttributes()
       .then((response: string[]) => {
-        expect(response.sort()).toEqual(Object.keys(dataset[0]).sort())
+        expect(response).toEqual(['*'])
       })
   })
   test(`${permission} key: Update searchable attributes`, async () => {
@@ -83,7 +83,7 @@ describe.each([
       .getIndex(index.uid)
       .getSearchableAttributes()
       .then((response: string[]) => {
-        expect(response.sort()).toEqual(Object.keys(dataset[0]).sort())
+        expect(response).toEqual(['*'])
       })
   })
 })