Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get typo tolerance return type #1518

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix get typo tolerance return type #1518

merged 2 commits into from
Jun 14, 2023

Conversation

bidoubiwa
Copy link
Contributor

Following #1455, this PR fixes the test of the PR.

riccox and others added 2 commits June 13, 2023 11:56
@riccox
fix(type): getTypoTolerance return value type (#1455)
ac37a81 
getTypoTolerance function should return type "TypoTolerance" rather than string array.
@bidoubiwa
Fix tests on getTypoTolerance return type
dcb2944
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 13, 2023
alallema
alallema approved these changes Jun 14, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@bidoubiwa bidoubiwa added bug Something isn't working skip-changelog The PR will not appear in the release changelogs and removed skip-changelog The PR will not appear in the release changelogs bug Something isn't working labels Jun 14, 2023
@bidoubiwa
Copy link
Contributor Author

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 14, 2023

Build succeeded:

@bidoubiwa bidoubiwa merged commit 532df46 into main Jun 14, 2023
@bidoubiwa bidoubiwa deleted the fix_get_typo_tolerance_return_type branch June 14, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

@brunoocasali brunoocasali Awaiting requested review from brunoocasali

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bidoubiwa @alallema @riccox