fix(type): getTypoTolerance return value type #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getTypoTolerance function should return type "TypoTolerance" rather than string array.
|
Hey @riccox thanks a lot for this contribution :) Could you change the failing test in tests/typo_tolerance.test.ts on line 43 ? |
|
Hey @riccox It would be nice if we could merge this nice contribution :) Can you fix the test? You only have to remove the If you have no time. I can merge this PR into my own PR |
|
@bidoubiwa Sorry to be later. |
bidoubiwa
changed the base branch from
main
to
fix_get_typo_tolerance_return_type
meili-bors bot
added a commit
that referenced
this pull request
Jun 14, 2023
1518: Fix get typo tolerance return type r=bidoubiwa a=bidoubiwa Following #1455, this PR fixes the test of the PR. Co-authored-by: Ricco Xie <[email protected]> Co-authored-by: Charlotte Vermandel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
getTypoTolerance function should return type "TypoTolerance" rather than string array.
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!