Skip to content

Add pagination and faceting types on settings for v0.28.0 #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 28, 2022
Merged

Add pagination and faceting types on settings for v0.28.0 #1281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c319f59
Add types on settings and fix tests
bidoubiwa Jun 27, 2022
39d1171
Merge branch 'bump-meilisearch-v0.28.0' of github.com:meilisearch/mei…
bidoubiwa Jun 27, 2022
ba04c47
Fix esm env test
bidoubiwa Jun 27, 2022
96d2199
Merge branch 'bump-meilisearch-v0.28.0' of github.com:meilisearch/mei…
bidoubiwa Jun 27, 2022
cb4e04f
Fix esm env test
bidoubiwa Jun 27, 2022
e7306e2
Merge branch 'bump-meilisearch-v0.28.0' of github.com:meilisearch/mei…
bidoubiwa Jun 27, 2022
8fb5ff7
Merge branch 'bump-meilisearch-v0.28.0' of github.com:meilisearch/mei…
bidoubiwa Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/types/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,13 @@ export type TypoTolerance = {
}
} | null

export type Faceting = {
maxValuesPerFacet?: number | null
}
export type PaginationSettings = {
maxTotalHits?: number | null
}

export type Settings = {
filterableAttributes?: FilterableAttributes
distinctAttribute?: DistinctAttribute
Expand All @@ -177,6 +184,8 @@ export type Settings = {
stopWords?: StopWords
synonyms?: Synonyms
typoTolerance?: TypoTolerance
faceting?: Faceting
pagination?: PaginationSettings
}

/*
Expand Down
12 changes: 12 additions & 0 deletions tests/settings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ const defaultSettings = {
disableOnWords: [],
disableOnAttributes: [],
},
pagination: {
maxTotalHits: 1000,
},
faceting: {
maxValuesPerFacet: 100,
},
}

jest.setTimeout(100 * 1000)
Expand Down Expand Up @@ -125,6 +131,12 @@ describe.each([{ permission: 'Master' }, { permission: 'Private' }])(
disableOnWords: ['prince'],
disableOnAttributes: ['comment'],
},
pagination: {
maxTotalHits: 1000,
},
faceting: {
maxValuesPerFacet: 100,
},
}
// Add the settings
const task = await client.index(index.uid).updateSettings(newSettings)
Expand Down