Add pagination and faceting types on settings for v0.28.0 #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
changed the title
…lisearch-js into fix_settings_tests_v0.28.0
…lisearch-js into fix_settings_tests_v0.28.0
bidoubiwa
force-pushed
the
bump-meilisearch-v0.28.0
branch
from
ba04c47 to
cb4e04f
Compare
…lisearch-js into fix_settings_tests_v0.28.0
bidoubiwa
force-pushed
the
bump-meilisearch-v0.28.0
branch
from
cb4e04f to
60db7c2
Compare
…lisearch-js into fix_settings_tests_v0.28.0
mdubus
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were failing because the new settings
paginationandfacetingwere not added in the settings types and default object.This PR fixes these tests.