Skip to content

Add sub-settings methods (to get, update and reset)#171

Merged
bors[bot] merged 1 commit intomeilisearch:mainfrom
tjakubo:add-sub-settings-methods
Oct 14, 2021
Merged

Add sub-settings methods (to get, update and reset)#171
bors[bot] merged 1 commit intomeilisearch:mainfrom
tjakubo:add-sub-settings-methods

Conversation

@tjakubo
Copy link
Copy Markdown
Contributor

@tjakubo tjakubo commented Oct 13, 2021

Change requested in #124
Complements #164

Everything done in the same manner as settings/displayed-attributes, please let me know if improvements are needed.

@curquiza curquiza changed the title Added remaining sub-settings methods (to get, update and reset) Added sub-settings methods (to get, update and reset) Oct 14, 2021
@curquiza curquiza changed the title Added sub-settings methods (to get, update and reset) Add sub-settings methods (to get, update and reset) Oct 14, 2021
@curquiza curquiza linked an issue Oct 14, 2021 that may be closed by this pull request
7 tasks
Copy link
Copy Markdown
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @tjakubo2!

bors merge

@bors
Copy link
Copy Markdown
Contributor

bors bot commented Oct 14, 2021

Build succeeded:

@bors bors bot merged commit 14f1895 into meilisearch:main Oct 14, 2021
@curquiza curquiza added the enhancement New feature or request label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement sub-settings methods

2 participants