Added settings/displayed-attributes methods (to get, update and reset) #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Oct 13, 2021
curquiza
changed the title
curquiza
approved these changes
Oct 13, 2021
Member
curquiza
left a comment
curquiza
left a comment
There was a problem hiding this comment.
thanks for this PR
bors merge
If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.
Contributor
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Oct 14, 2021
171: Add sub-settings methods (to get, update and reset) r=curquiza a=tjakubo2 Change requested in #124 Complements #164 Everything done in the same manner as settings/displayed-attributes, please let me know if improvements are needed. Co-authored-by: tjakubo2 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change requested in #124
SettingsTest.cswas restructured to remove code duplication and make further tests (for the rest of sub-settings) easier.If it is required, I can revert part of all of this restructuring (or adjust it as requested).
If this PR will be cleared, rest of sub-settings will be added as one.