-
Notifications
You must be signed in to change notification settings - Fork 32
Feature/Analytics #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature/Analytics #129
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
74cfe58
Create a version class to easily access package version data
brunoocasali e0b3be3
Expose headers method
brunoocasali 0e5bb32
Add Version.qualifiedVersion to headers
brunoocasali 65a882e
Make sure every version will be updated before the release
brunoocasali File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| class Version { | ||
| static const String current = '0.5.0'; | ||
|
|
||
| static String get qualifiedVersion { | ||
| return "MeiliSearch Dart (v${current})"; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import 'dart:io'; | ||
|
|
||
| import 'package:meilisearch/src/version.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| import 'utils/client.dart'; | ||
|
|
||
| void main() { | ||
| final RegExp semVer = new RegExp( | ||
| r"version\:.(0|[1-9]\d*)\.(0|[1-9]\d*)\.(0|[1-9]\d*)(?:-((?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*))?(?:\+([0-9a-zA-Z-]+(?:\.[0-9a-zA-Z-]+)*))?"); | ||
|
|
||
| group('Version', () { | ||
| test('matches with the current package version in pubspec.yaml', () { | ||
| final path = '${Directory.current.path}/pubspec.yaml'; | ||
| String data = new File(path).readAsStringSync(); | ||
| String? version = semVer.stringMatch(data)?.replaceFirst('version: ', ''); | ||
|
|
||
| expect(version, isNotNull); | ||
| expect(Version.current, isNotNull); | ||
| expect(Version.current, equals(version)); | ||
| }); | ||
| }); | ||
|
|
||
| group('Analytics', () { | ||
| setUpClient(); | ||
|
|
||
| test('sends the User-Agent header in every call', () { | ||
| final headers = client.http.headers(); | ||
|
|
||
| expect(headers.keys, contains('User-Agent')); | ||
| expect(headers['User-Agent'], isNotNull); | ||
| }); | ||
|
|
||
| test('has current version data from Version class', () { | ||
| final headers = client.http.headers(); | ||
|
|
||
| expect(headers['User-Agent'], equals(Version.qualifiedVersion)); | ||
| }); | ||
| }); | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't found the definition of the
$round_current_tagso I replaced with$current_tagThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was mistake, well spotted