Skip to content

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented Jan 18, 2022

  • Expose headers method
  • Create a Version class to easily access package version data.
  • Add Version.qualifiedVersion to headers

After the implementation the MeiliSearch server is outputting the expected 💯
[2022-01-19T18:33:47Z INFO actix_web::middleware::logger] 172.17.0.1:57704 "GET /keys HTTP/1.1" 200 14 "-" "MeiliSearch Dart (v0.5.0)" 0.000118

DISCLAIMER: I've tried other ways to collect these data eg.

  • Reading from pubspec.yaml:
    • This is not supported by dart native and flutter in the same way.
  • Generating the version class dynamically:
    • Due to the time constraint I was not able to do this, actually, I don’t know for sure if this is going to work exactly the same way as it is now.

Add dart support as requested here meilisearch/integration-guides#150

@brunoocasali
Copy link
Member Author

Dart doesn’t support this kind of feature yet dart-lang/sdk#18769

@brunoocasali brunoocasali added the enhancement New feature or request label Jan 18, 2022
Upgrade CONTRIBUTING and check-release script in order to prevent
new releases coming out without upgrading all the places with new version
@brunoocasali brunoocasali marked this pull request as ready for review January 19, 2022 19:05
echo "$file2: found $file_tag2 - expected $current_tag"
echo "$file3: found $file_tag3 - expected $current_tag"
echo "$file4: found $file_tag4 - expected $round_current_tag"
echo "$file4: found $file_tag4 - expected $current_tag"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't found the definition of the$round_current_tag so I replaced with $current_tag

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was mistake, well spotted

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done! 💪

@brunoocasali
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 20, 2022

Build succeeded:

@bors bors bot merged commit a52eabf into main Jan 20, 2022
@bors bors bot deleted the feature/analytics branch January 20, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants