Skip to content

Conversation

@guimachiavelli
Copy link
Member

This PR serves as a staging PR for the new pagination guide PR and the new pagination setting API reference.

@guimachiavelli guimachiavelli added this to the v0.28 milestone Jun 28, 2022
guimachiavelli and others added 15 commits July 4, 2022 13:00
1766: v0.28: Add pagination to core concepts/indexes r=guimachiavelli a=maryamsulemani97

Adds the pagination index setting to:
-`learn/core_concepts/indexes.md`
-`learn/configuration/settings.md`

Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Guillaume Mourier <[email protected]>
1759: v0.28: Pagination settings r=maryamsulemani97 a=guimachiavelli

Closes #1722 

Note for reviewers: you may ignore the failed CI checks, as they are currently failing due to a link to a document created in another PR.

Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: gui machiavelli <[email protected]>
Co-authored-by: Maryam Sulemani <[email protected]>
Co-authored-by: Maryam <[email protected]>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
@guimachiavelli guimachiavelli marked this pull request as ready for review July 7, 2022 10:40
Copy link
Contributor

@maryamsulemani97 maryamsulemani97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏃🏻‍♀️

@guimachiavelli
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 7, 2022

Build succeeded:

@bors bors bot merged commit 539530d into v0.28 Jul 7, 2022
@bors bors bot deleted the v0.28-pagination branch July 7, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants