-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make ES5 compatible #80
Conversation
@chrismayer this commit e1910ad should ensure that
|
@chrismayer the commit 9a66c88 also exposes the try {
myroutine(); // may throw three types of exceptions
} catch (e) {
if (e instanceof TypeError) {
// statements to handle TypeError exceptions
} else if (e instanceof RangeError) {
// statements to handle RangeError exceptions
} else if (e instanceof EvalError) {
// statements to handle EvalError exceptions
} else {
// statements to handle any unspecified exceptions
logMyErrors(e); // pass exception object to error handler
}
} (taken from https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/try...catch#conditional_catch-blocks ) |
Yes, makes totally sense. +1 for this. We just have to clarify where the export itself should be placed best. See my comment above. |
@chrismayer I responded to your comment inline. |
Since the Error stuff is moved to a separate PR (#83) this is good to go. |
fixes #73
This PR attempts to make
geoserver-node-client
compatible to ES5.TODO:
release-it
, fixed with e1910adinclude ES5 version in CI tests --> Issuemoved to Test ES5 functionality in test suite #82