Skip to content

Commit

Permalink
Expose GeoServerResponseError to user
Browse files Browse the repository at this point in the history
  • Loading branch information
@JakobMiksch
JakobMiksch committed May 18, 2022
1 parent e1910ad commit 9a66c88
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions geoserver-rest-client.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import SettingsClient from './src/settings.js';
import NamespaceClient from './src/namespace.js';
import AboutClient from './src/about.js';

export { GeoServerResponseError } from './src/util/geoserver.js'

This comment has been minimized.

Sign in to view

Copy link
@chrismayer

chrismayer May 19, 2022

Collaborator

Shouldn't the export be better placed in the source file of GeoServerResponseError itself? Or did you place it here by purpose?

This comment has been minimized.

Sign in to view

Copy link
@JakobMiksch

JakobMiksch May 19, 2022 •
edited
Loading

Author Contributor

The GeoServerResponseError is already exported internally here:

geoserver-node-client/src/util/geoserver.js

Lines 38 to 41 in 0d04e4f

export {
getGeoServerResponseText,
GeoServerResponseError
}

To my understanding, the file geoserver-rest-client.js is the top level entry point where all objects are exported that should be visible to the user of the library. That's why it is exported in geoserver-rest-client.js again.

This comment has been minimized.

Sign in to view

Copy link
@chrismayer

chrismayer May 19, 2022

Collaborator

OK for me then.

/**
* Client for GeoServer REST API.
* Has minimal basic functionality and offers REST client instances for
Expand Down

0 comments on commit 9a66c88

Please sign in to comment.