feat(dashboard): add campaign create to promotion UI #7306
Conversation
riqwan
commented
May 13, 2024
•
riqwan
commented
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
There was a problem hiding this comment.
How does it work if we have a promotion that is eligible for multiple currencies, but the campaign uses a single one, e.g. USD? I can't remember if we have talked about this previously.
If the promotion is configured for multiple currencies, perhaps a spend limit should be prohibited?
|
If I fill out the create campaign form, go back to promotion details, and then continue again to the campaign page, it seems all details are treated as unfilled in the form: CleanShot.2024-05-13.at.11.55.13.mp4 |
|
|
||
| <Form.Control> | ||
| {isTypeSpend ? ( | ||
| <CurrencyInput |
There was a problem hiding this comment.
suggestion: this should be disabled until currency is selected so we can display proper currency input (we usually add an info tooltip while on FormLabel in such cases)
There was a problem hiding this comment.
I tried this, but disabled doesn't seem to be working with currency input
There was a problem hiding this comment.
this disabled={!currencyValue} should work if you pass after props spread {...props} since it's probably overriding the prop
There was a problem hiding this comment.
in the new branch as well
| <Form.Label>{t("campaigns.budget.fields.limit")}</Form.Label> | ||
|
|
||
| <Form.Control> | ||
| {isTypeSpend ? ( |
There was a problem hiding this comment.
suggestion: we should reset this value when we switch between usage limit and amount
There was a problem hiding this comment.
I tried this here:
useEffect(() => {
form.setValue(`budget.limit`, undefined)
}, [watchValueType])
But its only resetting every 2nd click, any reccos on how to go about this?
There was a problem hiding this comment.
hmm seems that input is having problem with undefined, setting the value to "" should do the trick:
form.setValue(`${fieldScope}budget.limit`, "")
There was a problem hiding this comment.
nice that worked, moved it to the new branch.
...utes/campaigns/common/components/create-campaign-form-fields/create-campaign-form-fields.tsx
Show resolved
Hide resolved
