chore(): Autoload module resources #7291
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
|
adrien2p
requested review from
sradevski,
fPolic,
carlos-r-l-rodrigues and
olivermrbl
| ) | ||
|
|
||
| if (!hasConnectionLoader && models.length > 0) { | ||
| const connectionLoader = ModulesSdkUtils.mikroOrmConnectionLoaderFactory({ |
There was a problem hiding this comment.
would be good to get rid of MikroORM here eventually
There was a problem hiding this comment.
This is the default connection loader, since we are using mikro orm by default. Could you elaborate on your idea?
|
Next up is the module service boilerplate 😉 |
Yes, it will be the last one, then only the custom loaders will remain to export if you have any. This is because we need to keep the order in which they are exported as it might have an impact. Maybe we can think of something there too 👍 |
|
@olivermrbl should be good to re review if you want 👍 |
|
Will do! |
|
@shahednasser just for info it is merged now |
What
initializeFactoryin favor of usingmedusaAppShould drastically improve the module building DX by removing a lot of boilerplate to handle by the user, that plus the base entity should simplify quite a lot the flow cc @shahednasser
Note
I had to choose a way to identify connection and container loader from the exported loader from the module. I decided to go with named function
connectionLoaderandcontainerLoader, also, now the factories will return named function so if the user use the factories we are providing to build those loaders, the function will also be named and identified