Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): Use Node 16.14 in CLI workflow #5993

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Jan 3, 2024

What
Use Node version 16.14 in CLI workflow to eliminate an issue with a dependency requiring 16.14 or higher. Our default is 16.10.

This is not an ideal solution, but since we are moving toward Node 18 (and 20), I'd argue it's fine to have it as a temporary workaround for the CI to pass.

The reason for not defaulting to 16.14 for all workflows is that jest version 1.16.11 to 21 ships with a known memory issue, that would cause pipelines to fail.

@olivermrbl olivermrbl requested a review from a team as a code owner January 3, 2024 18:41
Copy link

changeset-bot bot commented Jan 3, 2024

⚠️ No Changeset found

Latest commit: f1ed39a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 7:06pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 7:06pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 7:06pm

@olivermrbl olivermrbl changed the title Chore/private modules chore(workflows): Use Node 16.14 in CLI workflow Jan 3, 2024
@olivermrbl
Copy link
Contributor Author

@adrien2p OK with this?

@adrien2p
Copy link
Member

adrien2p commented Jan 4, 2024

It is approved man 👌

@olivermrbl olivermrbl merged commit 1468646 into develop Jan 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants