Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Hide create fulfilment button when nothing left to fulfil #3515

Merged
merged 4 commits into from
Mar 20, 2023

Conversation

StephixOne
Copy link
Contributor

@StephixOne StephixOne commented Mar 17, 2023

Previously, if an order had two fulfilments that fully satisfied the order, then only one was shipped, the status would change to partially_shipped and show the "Create Fulfillment" button again, which would open a buggy modal with no items to fulfil. Added another check that looks at the items in the order and compares quantity and fulfilled_quantity, so that we can hide the button based on this as well, rather than just the order's fulfillment_status, which can be misleading.

Also added a status icon to the Fulfillment card's title bar for the partially_shipped status, as this area was blank before in that state.

Resolves CORE-1262

@StephixOne StephixOne requested a review from a team as a code owner March 17, 2023 12:57
@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2023

⚠️ No Changeset found

Latest commit: 15c2480

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 20, 2023 at 1:17PM (UTC)

Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 2176ff5 into develop Mar 20, 2023
@kodiakhq kodiakhq bot deleted the fix/create-fulfilment-button branch March 20, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants