Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(medusa): Missing location id on fulfillments #3462

Merged
merged 8 commits into from
Mar 14, 2023

Conversation

pKorsholm
Copy link
Contributor

@pKorsholm pKorsholm commented Mar 13, 2023

What

  • include location id when creating a fulfillment
  • Allow location updates to reservations without passing along quantity

Why

  • location_id on fulfillment was null after creation

Fixes CORE-1242, CORE-1243

@pKorsholm pKorsholm requested a review from a team as a code owner March 13, 2023 14:13
@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

🦋 Changeset detected

Latest commit: fde4f39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@medusajs/medusa Patch
@medusajs/inventory Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
medusa-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 10:57AM (UTC)

@srindom
Copy link
Collaborator

srindom commented Mar 13, 2023

@pKorsholm - any Linear tickets to link?

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the test, lgtm

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kodiakhq kodiakhq bot merged commit 30a3203 into develop Mar 14, 2023
@kodiakhq kodiakhq bot deleted the fix/missing-location-id-on-fulfillments branch March 14, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants