feat(admin-ui): added breadcrumbs for categories on create/edit modal #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab198d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
riqwan
force-pushed
the
feat/breadcrumb-category
branch
from
64f03b0 to
bebc399
Compare
olivermrbl
requested changes
Mar 8, 2023
There was a problem hiding this comment.
Great one @riqwan!
We should add a line break when the category breadcrumbs width expands beyond the modal width:
fPolic
reviewed
Mar 8, 2023
packages/admin-ui/ui/src/components/molecules/tree-crumbs/index.tsx
Outdated
Show resolved
Hide resolved
packages/admin-ui/ui/src/components/molecules/tree-crumbs/index.tsx
Outdated
Show resolved
Hide resolved
packages/admin-ui/ui/src/domain/product-categories/modals/add-product-category.tsx
Outdated
Show resolved
Hide resolved
packages/admin-ui/ui/src/domain/product-categories/modals/edit-product-category.tsx
Show resolved
Hide resolved
packages/admin-ui/ui/src/components/molecules/tree-crumbs/index.tsx
Outdated
Show resolved
Hide resolved
riqwan
force-pushed
the
feat/breadcrumb-category
branch
from
ec7a8df to
9d62760
Compare
|
@olivermrbl couldn't get this to work with CSS, so JS'd it.
|
|
@olivermrbl good catch, fixed the order. |
|
/snapshot this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
RESOLVES CORE-1210