-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admin-ui, medusa-react): product page categories management + nested multiselect #3401
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
🦋 Changeset detectedLatest commit: 0994462 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
de51f90
to
4ab8bcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really strong work @fPolic @riqwan. UX is soo nice!
Pending @kasperkristensen's approval :)
suggestion(if-minor, non-blocking): Invalidate query cache for products when categories are updated. Otherwise, the changes made in the category view are not reflected when you go to the product. A hard refresh is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! +1 on Oli's suggestion for a max height on the select, you could use the principle Ludvig has described here: https://www.figma.com/file/TW0kRpjhpsi3sR1u4a4wF8/Medusa-UI?node-id=103%3A1557&t=IODsksLnNzvb1YuP-4
What
RESOLVES CORE-1105
RESOLVES CORE-1106
RESOLVES CORE-1076