Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin-ui, medusa-react): product page categories management + nested multiselect #3401

Merged
merged 8 commits into from
Mar 7, 2023

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Mar 6, 2023

What

  • category management on the product page

RESOLVES CORE-1105
RESOLVES CORE-1106
RESOLVES CORE-1076

@vercel
Copy link

vercel bot commented Mar 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
staging ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 5:46PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
medusa-docs ⬜️ Ignored (Inspect) Mar 7, 2023 at 5:46PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

🦋 Changeset detected

Latest commit: 0994462

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
medusa-react Patch
@medusajs/admin-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@riqwan riqwan changed the base branch from master to feat/delimited-list March 6, 2023 23:29
@riqwan riqwan requested a review from fPolic March 6, 2023 23:30
Base automatically changed from feat/delimited-list to develop March 7, 2023 09:04
@fPolic fPolic marked this pull request as ready for review March 7, 2023 13:09
@fPolic fPolic requested a review from a team as a code owner March 7, 2023 13:09
@olivermrbl
Copy link
Contributor

suggestion(if-minor, non-blocking): Can't we set a max height on the select? If this is not a minor, we can do it in a follow up iteration.

CleanShot 2023-03-07 at 14 52 10@2x

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really strong work @fPolic @riqwan. UX is soo nice!

Pending @kasperkristensen's approval :)

suggestion(if-minor, non-blocking): Invalidate query cache for products when categories are updated. Otherwise, the changes made in the category view are not reflected when you go to the product. A hard refresh is required.

@fPolic fPolic changed the title feat(admin-ui): product page categories management + nested multiselect feat(admin-ui, medusa-react): product page categories management + nested multiselect Mar 7, 2023
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1 on Oli's suggestion for a max height on the select, you could use the principle Ludvig has described here: https://www.figma.com/file/TW0kRpjhpsi3sR1u4a4wF8/Medusa-UI?node-id=103%3A1557&t=IODsksLnNzvb1YuP-4

@olivermrbl olivermrbl merged commit 47d3440 into develop Mar 7, 2023
@olivermrbl olivermrbl deleted the feat/products-category-ui branch March 7, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants