-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(medusa-plugin-meilisearch): Update + improve Meilisearch plugin #3377
Conversation
🦋 Changeset detectedLatest commit: 5982c08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@olivermrbl - why is this closed? |
I am not entirely done with the PR. I can reopen it as draft, if that's better? :) |
@srindom Also, there are a couple of decisions to be made around the transformer strategy. I took a first stab at a solution, allowing developers to provide their own. Would love some feedback on it. And if you have any ideas for alternative approaches, please feel free to pitch in. |
If we proceed with these changes, the Algolia plugin should be updated as well. |
0116030
to
7714f52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the scope of that PR 💪
f5f3543
to
09ae16a
Compare
@srindom Would like to hear what you think about this proposal. Note, I've intentionally kept the scope small to solve the issues at hand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only have a small question on the version bump
What
meilisearch
dep to latest majormedusa-config.js
:Before
After
This is done to allow for additional configuration of indexes, that are not necessarily passed on query-time.
We introduce two new settings:
Meilisearch changed their primary key inference in the major release. Now we must be explicit when multiple properties end with
id
. Read more in their docs.The transformer allows developers to specify how their documents are stored in Meilisearch. It is configurable for each index.
Solves Discussion #3277
Solves #3373
Solves #2959 (no tests with the extender, as that is out of scope)