Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Modules initializer #3352

Merged
merged 73 commits into from
Mar 17, 2023
Merged

feat(medusa): Modules initializer #3352

merged 73 commits into from
Mar 17, 2023

Conversation

carlos-r-l-rodrigues
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues commented Mar 1, 2023 •
edited
Loading

What:
Module initializer for loading modules into projects.

Example:

import { InventoryServiceInitializeOptions, initialize } from "@medusajs/inventory"

const options: InventoryServiceInitializeOptions = {
  database: {
    type: "postgres",
    url: DB_URL,
  },
}

const inventoryService = await initialize(options)
const newInventoryItem = await inventoryService.createInventoryItem({
  sku: "sku_123",
})

console.log(newInventoryItem)

Fixes: CORE-1140

carlos-r-l-rodrigues and others added 22 commits February 23, 2023 16:52
@carlos-r-l-rodrigues
feat: scoped container for modules
c5d569b
@carlos-r-l-rodrigues
unit tests
3d22622
@carlos-r-l-rodrigues
yarn.lock
22195d6
@carlos-r-l-rodrigues
typo
695670b
@carlos-r-l-rodrigues
flat before filter
4068c6b
@carlos-r-l-rodrigues
test-request
c8a6c77
@carlos-r-l-rodrigues
MedusaModuleConfig type
280c83b
@carlos-r-l-rodrigues
dependencies
de45443
@carlos-r-l-rodrigues
address comments
e2ee720
@carlos-r-l-rodrigues
initialize
f2ad548
@carlos-r-l-rodrigues
add dependencies
7507a31
@carlos-r-l-rodrigues
Merge branch 'develop' into feat/modules-isolated-connection
e3dd118
@carlos-r-l-rodrigues
Merge branch 'feat/modules-isolated-connection' of github.com:medusaj…
a3be12f 
…s/medusa into modules_initialize
@carlos-r-l-rodrigues
yarn.lock
cdf5228
@carlos-r-l-rodrigues
yarn.lock
a986379
@carlos-r-l-rodrigues
Merge branch 'feat/modules-isolated-connection' of github.com:medusaj…
9d42772 
…s/medusa into feat/modules-isolated-connection
@carlos-r-l-rodrigues
Merge branch 'develop' into feat/modules-isolated-connection
b57d851
@carlos-r-l-rodrigues
optional eventBus and isolated modules migration
aca9b31
@carlos-r-l-rodrigues
stock location conn
5a14522
@carlos-r-l-rodrigues
check registration before inject
dac6068
@carlos-r-l-rodrigues
local container dependency
8fe87e5
@carlos-r-l-rodrigues
remove withtransaction
96758f2
@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: b0d0db5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@medusajs/inventory Patch
medusa-core-utils Patch
@medusajs/medusa Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@carlos-r-l-rodrigues carlos-r-l-rodrigues marked this pull request as ready for review March 2, 2023 11:29
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested a review from a team as a code owner March 2, 2023 11:29
@carlos-r-l-rodrigues carlos-r-l-rodrigues requested review from a team and removed request for a team March 2, 2023 11:29
adrien2p
adrien2p requested changes Mar 16, 2023
View reviewed changes
packages/inventory/src/migrations/run-migration.ts
function getDataSource(
dbData: InventoryServiceInitializeOptions["database"]
): DataSource {
return new DataSource({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it that way for now and see later for my comment

packages/inventory/src/services/inventory-item.ts Show resolved Hide resolved
packages/medusa/src/services/__tests__/event-bus.js Show resolved Hide resolved
adrien2p
adrien2p approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@olivermrbl olivermrbl changed the title Modules initialize feat(medusa): Modules initializer Mar 16, 2023
olivermrbl
olivermrbl approved these changes Mar 17, 2023
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is epic @carlos-r-l-rodrigues!

packages/medusa/src/commands/utils/get-migrations.js
Comment on lines +256 to +258
!moduleResolution.resolutionPath ||
moduleResolution.moduleDeclaration.scope !== "internal" ||
moduleResolution.moduleDeclaration.resources !== "isolated"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought(non-blocking): Move to module SDK

@carlos-r-l-rodrigues carlos-r-l-rodrigues merged commit aa690be into develop Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom left review comments

@olivermrbl olivermrbl olivermrbl approved these changes

@adrien2p adrien2p adrien2p approved these changes

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlos-r-l-rodrigues @srindom @adrien2p @olivermrbl