fix(medusa): update create fulfillment flow #3172

pKorsholm · 2023-02-03T11:50:13Z

What

Await adjustments made to reservations and inventory items
use correct map methods and db field

Why

An error thrown during inventory adjustment when creating a fulfillment would not necessarily cause a rollback
The code in pvinventoryService referenced some older fields for the product_variant_inventory table + used the wrong way to get map values

changeset-bot · 2023-02-03T11:50:16Z

🦋 Changeset detected

Latest commit: a8ebac2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@medusajs/medusa	Minor
@medusajs/inventory	Major
@medusajs/medusa-js	Major
medusa-plugin-restock-notification	Major
medusa-react	Major
@medusajs/stock-location	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

carlos-r-l-rodrigues

LGTM

non-blocking: We could add an integration test to this flow

packages/medusa/src/api/routes/admin/orders/create-fulfillment.ts

packages/medusa/src/services/product-variant-inventory.ts

adrien2p · 2023-02-21T15:04:29Z

integration-tests/plugins/__tests__/inventory/order/order.js

+      })
+      invItemId = invItem.id
+
+      await prodVarInventoryService.attachInventoryItem(variantId, invItem.id)


Question: Deos that mean that the SKU that is used to create the inventory item can be different than the variant SKU? are they meaning different thing?

yes, you will still have access to all the variants stock related fields, however they wont impact behavior if you use the inventory module.

integration-tests/plugins/__tests__/inventory/order/order.js

integration-tests/plugins/factories/simple-order-factory.ts

packages/medusa/src/api/routes/admin/orders/create-fulfillment.ts

olivermrbl · 2023-02-28T08:49:12Z

@pKorsholm Please resolve conflicts when time allows for it :)

olivermrbl

LGTM!

olivermrbl · 2023-02-28T09:41:30Z

Pending @adrien2p's approval :)

adrien2p

LGTM, one minore todo if needed

adrien2p · 2023-02-28T11:27:59Z

integration-tests/plugins/factories/simple-order-factory.ts

+  if (isDefined(data.sales_channel)) {
+    let sc
+
+    if (isString(data.sales_channel)) {
+      sc = await manager.findOne(SalesChannel, {
+        where: { id: data.sales_channel },
+      })
+    }
+
+    if (!sc) {
+      sc = await simpleSalesChannelFactory(
+        connection,
+        isString(data.sales_channel)
+          ? { id: data.sales_channel }
+          : data.sales_channel
+      )
+    }
+
+    sc_id = sc.id
+  }
+
+  if (sc_id) {
+    toCreate.sales_channel_id = sc_id
+  }


todo: if data.sales_channelis defined but is not a string, we don't do anything. I am missing it?

if data.sales_channel is defined but not a string we pass it into the sales channel factory on line 120

LOL, I did not see the not in the if constraint. I need to clean my glasses

adrien2p

LGTM

* update create fulfillment flow * move transaction service creation close to where it's used * integration tests * fix feedback * use transformBody * add changeset

pKorsholm changed the title ~~update create fulfillment flow~~ fix(medusa): update create fulfillment flow Feb 6, 2023

olivermrbl added the version: minor label Feb 6, 2023

pKorsholm changed the base branch from chore/integration-tests-stock-inventory to develop February 6, 2023 13:47

pKorsholm force-pushed the fix/reserve-item-fix branch from 34f3239 to 8ab6c79 Compare February 7, 2023 08:35

update create fulfillment flow

f13fd13

pKorsholm force-pushed the fix/reserve-item-fix branch from 8ab6c79 to f13fd13 Compare February 7, 2023 08:36

Merge branch 'develop' into fix/reserve-item-fix

924f553

pKorsholm marked this pull request as ready for review February 7, 2023 08:37

pKorsholm requested a review from a team as a code owner February 7, 2023 08:37

carlos-r-l-rodrigues approved these changes Feb 7, 2023

View reviewed changes

adrien2p requested changes Feb 14, 2023

View reviewed changes

packages/medusa/src/api/routes/admin/orders/create-fulfillment.ts Show resolved Hide resolved

packages/medusa/src/api/routes/admin/orders/create-fulfillment.ts Show resolved Hide resolved

packages/medusa/src/services/product-variant-inventory.ts Show resolved Hide resolved

pKorsholm and others added 3 commits February 16, 2023 08:30

Merge branch 'develop' into fix/reserve-item-fix

079e6be

move transaction service creation close to where it's used

79e5881

integration tests

d2c4dff

pKorsholm requested a review from adrien2p February 16, 2023 13:31

pKorsholm added 2 commits February 16, 2023 14:31

Merge branch 'develop' into fix/reserve-item-fix

43f770c

Merge branch 'develop' into fix/reserve-item-fix

b310c55

pKorsholm requested review from olivermrbl and srindom February 20, 2023 08:41

pKorsholm added 2 commits February 21, 2023 09:47

Merge branch 'develop' into fix/reserve-item-fix

f3d93a0

Merge branch 'develop' into fix/reserve-item-fix

260aa26

adrien2p requested changes Feb 21, 2023

View reviewed changes

pKorsholm and others added 3 commits February 22, 2023 11:44

Merge branch 'develop' into fix/reserve-item-fix

5141f8f

fix feedback

520b300

use transformBody

6911c42

pKorsholm requested a review from adrien2p February 22, 2023 10:56

add changeset

bf64954

Merge branch 'develop' into fix/reserve-item-fix

23aed0e

olivermrbl approved these changes Feb 28, 2023

View reviewed changes

adrien2p approved these changes Feb 28, 2023

View reviewed changes

riqwan approved these changes Feb 28, 2023

View reviewed changes

pKorsholm force-pushed the fix/reserve-item-fix branch from a436b01 to 23aed0e Compare February 28, 2023 13:39

Merge branch 'develop' into fix/reserve-item-fix

a8ebac2

adrien2p approved these changes Feb 28, 2023

View reviewed changes

pKorsholm merged commit 5eb61fa into develop Feb 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(medusa): update create fulfillment flow #3172

fix(medusa): update create fulfillment flow #3172

pKorsholm commented Feb 3, 2023 •

edited

Loading

changeset-bot bot commented Feb 3, 2023 •

edited

Loading

carlos-r-l-rodrigues left a comment

adrien2p Feb 21, 2023

pKorsholm Feb 22, 2023

olivermrbl commented Feb 28, 2023

olivermrbl left a comment

olivermrbl commented Feb 28, 2023

adrien2p left a comment

adrien2p Feb 28, 2023

pKorsholm Feb 28, 2023

adrien2p Feb 28, 2023

adrien2p left a comment

fix(medusa): update create fulfillment flow #3172

fix(medusa): update create fulfillment flow #3172

Conversation

pKorsholm commented Feb 3, 2023 • edited Loading

changeset-bot bot commented Feb 3, 2023 • edited Loading

🦋 Changeset detected

carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

adrien2p Feb 21, 2023

Choose a reason for hiding this comment

pKorsholm Feb 22, 2023

Choose a reason for hiding this comment

olivermrbl commented Feb 28, 2023

olivermrbl left a comment

Choose a reason for hiding this comment

olivermrbl commented Feb 28, 2023

adrien2p left a comment

Choose a reason for hiding this comment

adrien2p Feb 28, 2023

Choose a reason for hiding this comment

pKorsholm Feb 28, 2023

Choose a reason for hiding this comment

adrien2p Feb 28, 2023

Choose a reason for hiding this comment

adrien2p left a comment

Choose a reason for hiding this comment

pKorsholm commented Feb 3, 2023 •

edited

Loading

changeset-bot bot commented Feb 3, 2023 •

edited

Loading