Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Change customer to account_holder to be one-to-many #11803

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: Change customer to account_holder to be one-to-many #11803

wants to merge 1 commit into from
+20 −7

Conversation

sradevski
Copy link
Member

This adds support for a customer to be able to have multiple account holders, therefore supporting multiple payment providers at the same time.

BREAKING: If you were using customer.account_holder in your custom implementation, you will need to change it to customer.account_holders and choose the relevant one for the provider_id you want to use. If you haven't done anything custom with payments and account holders, there are no breaking changes

@sradevski sradevski requested a review from a team as a code owner March 11, 2025 11:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9507a1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 11:54am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 11:54am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 11:54am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 11:54am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 11:54am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 11:54am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 11:54am
user-guide ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 11:54am

@sradevski sradevski force-pushed the feat/change-account-holder-to-one-to-many branch from 74db4ad to be08001 Compare March 11, 2025 11:02
@sradevski
Copy link
Member Author

/snapshot-this

@sradevski sradevski force-pushed the feat/change-account-holder-to-one-to-many branch from be08001 to 9507a1d Compare March 11, 2025 11:52
@sradevski
Copy link
Member Author

/snapshot-this

@github-actions GitHub Actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add [email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]
yarn add @medusajs/[email protected]

Latest commit: ec56a8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
has: breaking changes team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @carlos-r-l-rodrigues @olivermrbl