-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update fulfillment provider module docs to reflect CalculatedShippingOptionPrice #10778
docs: update fulfillment provider module docs to reflect CalculatedShippingOptionPrice #10778
Conversation
… value of type CalculatedShippingOptionPrice
|
@ranjithkumar8352 is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Just a few comments, and please reflect those on the generated reference.
Thanks @shahednasser, I have implemented the suggestions accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
The return value below the example for the
calculatePrice
method is shown correctly asCalculatedShippingOptionPrice
but the example is not updated in the guide "How to Create a Fulfillment Provider Module"This PR updates the example in the guide and the TS doc