Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update fulfillment provider module docs to reflect CalculatedShippingOptionPrice #10778

Conversation

ranjithkumar8352
Copy link
Contributor

The return value below the example for the calculatePrice method is shown correctly as CalculatedShippingOptionPrice but the example is not updated in the guide "How to Create a Fulfillment Provider Module"

This PR updates the example in the guide and the TS doc

Copy link

changeset-bot bot commented Dec 31, 2024

⚠️ No Changeset found

Latest commit: 4f63527

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 31, 2024

@ranjithkumar8352 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@ranjithkumar8352 ranjithkumar8352 changed the title Update fulfillment provider module docs to reflect CalculatedShippingOptionPrice docs: update fulfillment provider module docs to reflect CalculatedShippingOptionPrice Dec 31, 2024
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just a few comments, and please reflect those on the generated reference.

packages/core/utils/src/fulfillment/provider.ts Outdated Show resolved Hide resolved
packages/core/utils/src/fulfillment/provider.ts Outdated Show resolved Hide resolved
@ranjithkumar8352
Copy link
Contributor Author

Nice catch! Just a few comments, and please reflect those on the generated reference.

Thanks @shahednasser, I have implemented the suggestions accordingly.

Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@kodiakhq kodiakhq bot merged commit 1ef3e4b into medusajs:develop Dec 31, 2024
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants