fix(js-sdk, medusa): Allow users to change their mind during the checkout process #10671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the payment collection accordingly - refresh the payment collection on every POST request in the API (makes use of the pre-existing workflow that only creates a new collection if the existing one is out of sync with the cart) - change the frontend library to request a check of the payment collection everytime before initializing a payment session
|
|
@damianr13 is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks @damianr13, let me get back to you on this. 🤞🏻 |
riqwan
reviewed
Dec 19, 2024
Comment on lines
+967
to
+975
| await this.client.fetch<HttpTypes.StorePaymentCollectionResponse>( | ||
| `/store/payment-collections`, | ||
| { | ||
| method: "POST", | ||
| headers, | ||
| body: collectionBody, | ||
| } | ||
| ) | ||
| ).payment_collection.id |
There was a problem hiding this comment.
sugg: you can return this function directly and remove the Get from underneath
There was a problem hiding this comment.
Are they equivalent though? One is a payment collection the other is a payment session.
Before my changes they were still called together but only when the payment collection id was not defined.
| await refreshPaymentCollectionForCartWorkflow(req.scope).run({ | ||
| input: { cart_id }, | ||
| }) | ||
| paymentCollection = await getPaymentCollectionForCart(req) |
There was a problem hiding this comment.
sugg: can you remove this function here and add this on line 48 instead:
const paymentCollection = await refetchEntity(
"payment_collection",
cartCollectionRelation?.payment_collection?.id,
req.scope,
req.remoteQueryConfig.fields
)
|
@damianr13 i have a similar issue when customer choose shipping method for his cart and change his mind. Here the error triggered when add NEW item in the cart : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and update the payment collection accordingly
Addresses #10670