Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mdx): add additional typings to mdx api #1211

Merged
merged 4 commits into from
Aug 3, 2020

Conversation

lonyele
Copy link
Contributor

@lonyele lonyele commented Aug 3, 2020

Issue: #1210

What I did

Add skipExport and wrapExport typings to mdx api

Context

First of all, thanks for adding some typescript support to mdx. I found that as #1079 was landed, it misses some typings. I personally had a problem with skipExport but I found that wrapExport looks like it needs typing too. Let me know if something needs to be changed

@vercel
Copy link

vercel bot commented Aug 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mdx/mdx/3bg6nxwfl
✅ Preview: https://mdx-git-fork-lonyele-feature-enhance-mdx-typings.mdx.vercel.app

@vercel vercel bot temporarily deployed to Preview August 3, 2020 08:01 Inactive
@lonyele
Copy link
Contributor Author

lonyele commented Aug 3, 2020

hm... both yarn test and yarn test-types works ok on my machine(Mac 10.15.2, node 14.4.0, yarn 1.21.1) Probably help is needed here

Copy link
Member

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

packages/mdx/types/index.d.ts Outdated Show resolved Hide resolved
packages/mdx/types/index.d.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 3, 2020 13:56 Inactive
@johno johno merged commit d76085f into mdx-js:next Aug 3, 2020
@vercel vercel bot temporarily deployed to Preview August 3, 2020 13:57 Inactive
@lonyele lonyele deleted the feature/enhance-mdx-typings branch August 4, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants