types: add typescript typings for @mdx/loasder, @mdx-js/mdx, @mdx-js/react, @mdx-js/runtime, @mdx-js/vue, @mdx/vue-loader #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/runtime, and @mdx-js/vue
|
This pull request is being automatically deployed with Vercel (learn more). |
ChristianMurphy
commented
May 20, 2020
| @@ -50,6 +52,7 @@ | |||
| "babel-plugin-macros": "2.8.0", | |||
| "babel-plugin-remove-export-keywords": "^1.6.2", | |||
| "babel-plugin-transform-vue-jsx": "4.0.1", | |||
| "dtslint": "3.6.3", | |||
There was a problem hiding this comment.
pulled dtslint to the top level, since the same version can and should be used to test all packages
| @@ -31,6 +34,9 @@ | |||
| "webpack", | |||
| "loader" | |||
| ], | |||
| "scripts": { | |||
| "test-types": "dtslint types" | |||
There was a problem hiding this comment.
dtslint doesn't seem to support patterns.
I tried adding dtslint packages/*/types to handle all packages at once, that didn't work, so opted to add the script at the package level, and use lerna to run all of them.
ChristianMurphy
added
☂️ area/types
|
ci failure matches current |
|
Awesome, thanks! I'll go ahead and fix the error in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re-applies #811
is part of #1078