feat: enable ecmaFeatures.jsx in exported configs#608
feat: enable ecmaFeatures.jsx in exported configs#608controversial wants to merge 4 commits intomdx-js:masterfrom
ecmaFeatures.jsx in exported configs#608Conversation
🦋 Changeset detectedLatest commit: 57444a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
CI is broken, and the test should only run on ESLint 10. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 273 273
Branches 53 52 -1
=========================================
Hits 273 273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @JounQin - I fixed the CI failures (sorry for that) and updated the test to run on ESLint 10 only However I don’t think the CI actually runs any tests on ESLint 10? The CI workflow only installs a new ESLint version if eslint-mdx/.github/workflows/ci.yml Lines 45 to 48 in f717ff2 |
0c92360 to
57444a9
Compare
|
I tried updating the CI to run on ESLint 10 in #609 but there are many more unrelated CI failures; many other parts of the testing infrastructure do not support ESLint 10 (eslint-plugin-react crashes, the version of without ESLint 10 testing infrastructure in this project, it’s not really feasible to add a test for ESLint 10 behavior, unfortunately |
Initial checklist
Description of changes
Adds
ecmaFeatures: { jsx: true }to the premade configs for mdx files so that ESLint 10 can identify & track JSX references in MDX files.Closes #444 for ESLint 10 users