fix: remove unneeded dependency upon uvu#600
Conversation
🦋 Changeset detectedLatest commit: a24c1cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 272 272
Branches 48 49 +1
=========================================
Hits 272 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes the uvu dependency from eslint-mdx by replacing its ok assertion helper with Node’s built-in node:assert, reducing the transitive dependency surface area.
Changes:
- Replace
uvu/assertusage withnode:assertin runtime code. - Remove
uvufrompackages/eslint-mdx/package.json. - Update lockfile to drop
uvuand its transitive dependencies, and add a changeset for a patch release.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes uvu and its transitive dependencies from the lockfile graph. |
| packages/eslint-mdx/src/worker.ts | Switches assertion import from uvu/assert to node:assert. |
| packages/eslint-mdx/src/tokens.ts | Switches assertion import from uvu/assert to node:assert. |
| packages/eslint-mdx/package.json | Removes uvu from dependencies. |
| .changeset/remove-uvu.md | Adds a patch changeset documenting the dependency removal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@wooorm Could you help to set OIDC publishing for |
|
Sure, but maybe that’s separate? I need:
|
|
workflow name: https://github.com/mdx-js/eslint-mdx/blob/master/.github/workflows/release.yml No environment name needed |
|
Can we land this without needing to setup NPM trusted publishers? Does it auto publish? |
I don't have publish permission, the npm token needs to be updated. cc @wooorm |
|
Thank you. |
Initial checklist
Description of changes
The
uvudependency is unnecessary since it can be easily replaced withnode:assert. The goal here is to reduce unnecessary dependencies since they come with their own security issues. This issue surfaced because of the recent issue withdiff.