Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): links overflow #5107

Closed
wants to merge 1 commit into from
Closed

fix(sidebar): links overflow #5107

wants to merge 1 commit into from

Conversation

rafae2k
Copy link

@rafae2k rafae2k commented Dec 26, 2021

Fixes #5031, #5105, #4973, #4635, #2221

Changes proposed in this pull request:

  • Fix content overflow of links within sidebar component keeping icon and link inline
  • Add property word-break: break-all to .sidebar li class

Fixes mdn#5031, mdn#5105, mdn#4635, #4973

Changes proposed in this pull request:

- Fix content overflow of links within sidebar component keeping icon and link inline
- Add  property ```word-break: break-all``` to ```.sidebar li``` class
@rafae2k
Copy link
Author

rafae2k commented Dec 26, 2021

@schalkneethling although it's a very old problem that's been addressed in the frontend roadmap, I think this is a easy fix to be implemented in time a redesign is not ready yet , that will improve accessibility and readability of MDN.

@rafae2k rafae2k changed the title fix: sidebar links overflow fix(sidebar): links overflow Jan 3, 2022
@schalkneethling
Copy link

Hey @rafae2k,

Thank you so much for your contribution and your patience. The MDN platform is undergoing a redesign at the moment and the sidebars are changing a lot as part of it. This issue has already been addressed there so, unfortunately, merging this will only get overridden in a few weeks with the redesign.

As such I am going to have to close this pull request. MY apologies and I hope this does not discourage you from contributing in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar on page with id=sidebar-quicklinks and class = sidebar needs css update.
2 participants