Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with "BigInt": Left sidebar blends with text #5105

Closed
Tracked by #5127
PythonCoderAS opened this issue Dec 24, 2021 · 5 comments
Closed
Tracked by #5127

Issue with "BigInt": Left sidebar blends with text #5105

PythonCoderAS opened this issue Dec 24, 2021 · 5 comments

Comments

@PythonCoderAS
Copy link

MDN URL: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

What information was incorrect, unhelpful, or incomplete?

The left sidebar clips with the actual text and makes it hard to read.

image

Specific section or headline?

Most noticeable near the Operators heading.

What did you expect to see?

Sidebar separated by whitespace

Did you test this? If so, how?

N/A

MDN Content page report details
@Andrew-Cottrell
Copy link

I can reproduce using Chrome 96.0.4664.110 with the browser window sized such that

window.innerWidth === 1024; // true

In my opinion, the following improves the layout

.sidebar {
    overflow-x: hidden;
}

This issue occurs on every page that displays the Object prototype's methods in the sidebar, including the Object page, as the text "Object.prototype.propertyIsEnumerable()" is too wide to fit in the available space.

@AnilSeervi
Copy link
Contributor

It looks fine on firefox(wrapping the text to next line at-word). Issue seems to be with chromium browsers.

It's because the text is within the code block and chromium browsers for some reason arent able to figure out where to wrap text within <code>.

@Andrew-Cottrell
Copy link

The following helps Chrome 96 and probably other Chromium browsers

.sidebar code {
    word-wrap: break-word;
}

@AnilSeervi
Copy link
Contributor

Yes.
Code blocks by default have that(word-wrap: break-word) style.

That does work, but not as good as it does in firefox.

Edit: found similar issue in #4635

The simple solution here would be to remove the word-wrap property on .sidebar code.

@wbamberg wbamberg transferred this issue from mdn/content Dec 24, 2021
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 24, 2021
rafae2k added a commit to rafae2k/yari that referenced this issue Dec 26, 2021
Fixes mdn#5031, mdn#5105, mdn#4635, #4973

Changes proposed in this pull request:

- Fix content overflow of links within sidebar component keeping icon and link inline
- Add  property ```word-break: break-all``` to ```.sidebar li``` class
@schalkneethling
Copy link

Hey @PythonCoderAS, @Andrew-Cottrell, and @AnilSeervi. Thank you for raising this issue. It is indeed problematic. This is being addressed as part of the current redesign that is underway. As such, the work is tracked elsewhere. Closing this one to avoid duplication.

@schalkneethling schalkneethling removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants