Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiment): replace test group for Web/API page titles #10955

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Apr 18, 2024

Summary

Follow-up of #10926 (MP-1054).

Problem

The previous test group for the experiment was accidentally sampled only from a subset of 2719 affected pages, but 4824 pages follow the name pattern.

Solution

Draw a new sample from all 4824 pages and replace the old sample.

Note: The experiment was not yet deployed on production, so there is no risk for the experiment.


How did you test this change?

This PR just changes data.

The previous test group was not sampled from
the full population of affected pages.
@caugner caugner requested a review from a team as a code owner April 18, 2024 19:25
@caugner caugner changed the title fix(experiment): replace test group fix(experiment): replace test group for Web/API page titles Apr 18, 2024
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval.

@caugner caugner merged commit 1dfb5b2 into main Apr 18, 2024
12 checks passed
@caugner caugner deleted the MP-1054-fix-test-group branch April 18, 2024 19:50
mostafaroshdy1 pushed a commit to mostafaroshdy1/yari that referenced this pull request Apr 19, 2024
The previous test group was not sampled from
the full population of affected Web/API pages.
caugner added a commit that referenced this pull request May 30, 2024
caugner added a commit that referenced this pull request May 30, 2024
* Revert "fix(experiment): replace test group for Web/API page titles (#10955)"

This reverts commit 559f8fd.

* Revert "feat(experiment): rewrite Web/API page titles (#10926)"

This reverts commit b625183.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant