Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(article-footer): link to translated-content for other locales #10743

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

hochan222
Copy link
Member

@hochan222 hochan222 commented Mar 19, 2024

Summary

Improve learn how to contribute footer for locales.

In the issue below, a contributor suggested linking a locale to the "Learn how to contribute" link.

Problem

Even if it is a locale page, it always links to "https://github.com/mdn/content/blob/main/CONTRIBUTING.md".

Solution

link "https://github.com/mdn/translated-content/blob/main/CONTRIBUTING.md" for locale.

@hochan222 hochan222 requested a review from a team as a code owner March 19, 2024 13:36
@hochan222 hochan222 changed the title Improve "Learn how to contribute" footer Improve "Learn how to contribute" footer for locales Mar 19, 2024
@caugner caugner changed the title Improve "Learn how to contribute" footer for locales fix(article-footer): link to translated-content for other locales Mar 19, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hochan222 I allowed myself to push two changes to align the check with the NewIssueOnGitHubLink component, i.e. to use the doc's locale, rather than the locale from the URl, and to simply compare against the default locale (en-US).

Let me know if that works, and we can get this landed. 😉

@hochan222
Copy link
Member Author

@caugner That's a great. Thank you! Also it works!

Have a good day 🙇🙇

@caugner caugner merged commit fd3f69c into mdn:main Mar 19, 2024
10 checks passed
@hochan222 hochan222 deleted the feature/improve-how-to-contribute branch March 19, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants