Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(macros/EmbedLiveSample): deprecate screenshot URL parameter #10697

Merged
merged 2 commits into from
Mar 15, 2024
Merged

chore(macros/EmbedLiveSample): deprecate screenshot URL parameter #10697

merged 2 commits into from
Mar 15, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Mar 13, 2024

Summary

The EmbedLiveSample macro doesn't use the $3 param (screenshot URL) in EN content.
Adding a deprecatedParams flaw for it

Screenshots

Screenshot 2024-03-13 at 11 55 49 AM

How did you test this change?

  • yarn && yarn dev
  • visit http://localhost:3000
  • Added the updated macro to a document and visited on http://localhost:3000/...#_flaws

Related issues and pull requests:

Removals PRs:

@bsmth bsmth requested a review from a team as a code owner March 13, 2024 12:07
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Mar 13, 2024
@caugner caugner changed the title chore(macros): Deprecate screenshot URL parameter in EmbedLiveSample chore(macros/EmbedLiveSample): deprecate screenshot URL parameter Mar 15, 2024
caugner
caugner approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion.

kumascript/macros/EmbedLiveSample.ejs Outdated Show resolved Hide resolved
@caugner caugner merged commit 2a24620 into mdn:main Mar 15, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Mar 15, 2024
Merged
@bsmth bsmth deleted the macro-deprecation-embedlivesample-screenshot-param branch March 15, 2024 17:09
@bsmth
Copy link
Member Author

bsmth commented Mar 15, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsmth @caugner