Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): Remove screenshots from EmbedLiveSample calls #32588

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Mar 6, 2024

Description

This PR removes screenshots in EmbedLiveSample calls. The screenshots are used in examples that have good browser support, so they serve no purpose that I can see. This PR cleans up some leftovers after #32505.

Motivation

Removing binaries from the repository. This is also an opportunity to deprecate the parameter for including screenshots in the live samples.

Related issues and pull requests

@bsmth bsmth requested a review from a team March 6, 2024 16:50
@bsmth bsmth requested review from a team as code owners March 6, 2024 16:50
@bsmth bsmth requested review from Ryuno-Ki, sideshowbarker and dipikabh and removed request for a team March 6, 2024 16:51
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:SVG SVG docs labels Mar 6, 2024
@bsmth bsmth added the macros Work relating to macro refactoring or removal label Mar 6, 2024
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Mar 6, 2024
@dipikabh dipikabh self-assigned this Mar 6, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you!

@dipikabh dipikabh merged commit c8b4474 into mdn:main Mar 6, 2024
8 checks passed
@bsmth bsmth deleted the macro-screenshot-fix-2 branch March 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:SVG SVG docs Content:WebAPI Web API docs macros Work relating to macro refactoring or removal size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants