fix(bcd): Fix tooltip for removed features #10684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The original change was here: 086b125#diff-961a7b8c5428138ce0fc0b6447850d8bd038a9463114fcdd246d37d312736a4f. Perhaps @kkellydesign had some rationale for it. |
caugner
approved these changes
Mar 15, 2024
|
Awesome, @danielhjacobs, we're glad to have you, thanks a lot! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8587
Problem
It used to be that the "Removed in..." note used the footnote icon. After the redesign back in 2022, the icon was changed to the disabled icon, which if you didn't know the codebase would make perfect sense. However, the disabled icon has the tooltip "User must explicitly enable this feature."
Solution
Switch back to the footnote tooltip.
Screenshots
Before
After