Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect browser compatibility tooltips #8587

Closed
3 tasks done
FozzieHi opened this issue Apr 6, 2023 · 1 comment · Fixed by #10684
Closed
3 tasks done

Incorrect browser compatibility tooltips #8587

FozzieHi opened this issue Apr 6, 2023 · 1 comment · Fixed by #10684
Labels
browser-compat issues related to the browser compatibility data tables (BCD) 🐛 bug Something isn't working, or isn't working as expected

Comments

@FozzieHi
Copy link

FozzieHi commented Apr 6, 2023

Summary

Split from #8586

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerContainer#browser_compatibility

If you go to Edge under the messageerror event row you will see the tooltip "User must explicitly enable this feature." for "Removed in 79 and later":
image

URL

https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerContainer#browser_compatibility

Reproduction steps

N/A

Expected behavior

N/A

Actual behavior

N/A

Device

Desktop

Browser

Firefox

Browser version

Stable

Operating system

Linux

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Apr 6, 2023
@mirunacurtean mirunacurtean added 🐛 bug Something isn't working, or isn't working as expected browser-compat issues related to the browser compatibility data tables (BCD) and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Apr 12, 2023
@github-actions github-actions bot added the idle label Jan 24, 2024
@danielhjacobs
Copy link
Contributor

It used to be that the "Removed in..." note used the footnote icon:

iconName: "footnote",
label: (
<>
Removed in {labelFromString(item.version_removed, browser)}{" "}
and later
</>
),

After the redesign back in 2022, the icon was changed to the disabled icon, which if you didn't know the codebase would make perfect sense:

iconName: "disabled",
label: (
<>
Removed in {labelFromString(item.version_removed, browser)}{" "}
and later
</>
),

The disabled icon has the mentioned tooltip:

disabled: "User must explicitly enable this feature.",

The footnote icon's tooltip is this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD) 🐛 bug Something isn't working, or isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants