Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-cn: translate for CookieStoreManager.subscribe method #20347

Merged
merged 4 commits into from
Jun 3, 2024
Merged

zh-cn: translate for CookieStoreManager.subscribe method #20347

merged 4 commits into from
Jun 3, 2024

Conversation

xyy94813
Copy link
Contributor

Description

translate docs of CookieStoreManager.subscribe method to zh-cn.

Motivation

Learning and translating.

Additional details

Origin content has wrong desc.

Related issues and pull requests

@xyy94813 xyy94813 requested a review from a team as a code owner May 13, 2024 14:59
@xyy94813 xyy94813 requested review from JasonLamv-t and removed request for a team May 13, 2024 14:59
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited
Loading

Preview URLs

Flaws (4)

URL: /zh-CN/docs/Web/API/CookieStoreManager/subscribe
Title: CookieStoreManager：subscribe() 方法
Flaw count: 4

  • macros:
    • /zh-CN/docs/Web/API/CookieStoreManager does not exist but fell back to /en-US/docs/Web/API/CookieStoreManager
    • /zh-CN/docs/Web/API/ServiceWorkerRegistration does not exist but fell back to /en-US/docs/Web/API/ServiceWorkerRegistration
    • /zh-CN/docs/Web/API/ServiceWorkerRegistration/scope does not exist but fell back to /en-US/docs/Web/API/ServiceWorkerRegistration/scope
    • /zh-CN/docs/Web/API/ServiceWorkerRegistration does not exist but fell back to /en-US/docs/Web/API/ServiceWorkerRegistration

(comment last updated: 2024-06-03 12:57:10)

@xyy94813 @github-actions
Update files/zh-cn/web/api/cookiestoremanager/subscribe/index.md
97d2a4a 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@yin1999 yin1999 marked this pull request as draft May 14, 2024 01:10
@yin1999
Copy link
Member

yin1999 commented May 14, 2024

Please mark this PR as ready for review after the depends got merged.

xyy94813
xyy94813 commented May 14, 2024
View reviewed changes
Copy link
Contributor Author

@xyy94813 xyy94813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Service Worker 注册器" -> “Service Worker Registration”

files/zh-cn/web/api/cookiestoremanager/subscribe/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/cookiestoremanager/subscribe/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/cookiestoremanager/subscribe/index.md Outdated Show resolved Hide resolved
xyy94813
xyy94813 commented May 31, 2024
View reviewed changes
Copy link
Contributor Author

@xyy94813 xyy94813 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sync l18n

files/zh-cn/web/api/cookiestoremanager/subscribe/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 marked this pull request as ready for review June 2, 2024 06:53
@yin1999 yin1999 merged commit 224ad41 into mdn:main Jun 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@skyclouds2001 skyclouds2001 skyclouds2001 left review comments

@yin1999 yin1999 yin1999 approved these changes

@JasonLamv-t JasonLamv-t Awaiting requested review from JasonLamv-t JasonLamv-t is a code owner automatically assigned from mdn/yari-content-zh

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xyy94813 @yin1999 @skyclouds2001