-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ja): WebAssembly/JavaScript_interface/Global 以下を更新 #14909
Conversation
CI fails here:
Failing: gh api repos/mdn/translated-content/compare/ba5878ee9ac3f9d3374d82186771a07c1abbf364...5843766c13a3eda14723df4b4ac226aa8548828f And Looks like a If you run: gh api repos/mdn/translated-content/compare/ba5878ee9ac3f9d3374d82186771a07c1abbf364...5843766c13a3eda14723df4b4ac226aa8548828f > output.json
tail output.json You can see it chokes at line 22 at the (�) char:
And can be reproduced by getting the commit that introduced the character: gh api repos/mdn/translated-content/commits/7144ca0458a33571ade432951827e61443d85ff5 > output.json
tail output.json
# ...
g に存在する対になっていないサロゲートコードポイントは、ブラウザーが Unicode の「置換文字」 U+FFFD, (% |
@bsmth However, the unicode character reference has been introduced from the English version of that time (before the commit mdn/content@f284782#diff-ab009fdab2d2d37768c947522209ddd397af896272bc13e84e7d61e0151f7cc8). This PR removes the character (corresponding to the commit above for the |
My pleasure. Any pull request that has a diff including this character This PR removes it so other branches updating from main won't experience this problem, so I believe it's safe to merge. What do you think? |
@bsmth |
I would also like to have a deeper look into GitHub cli. I think we have a chance to fix this so that future CIs will handle this special character correctly :) |
True, we might want to report this as an issue on the repo that fetching patches containing this character with |
I can now confirm that the issue is caused by a dependency of the GitHub cli: It is caused by the sanitizer used by the transformer. I'll dig further into this issue :) |
Test PR to reproduce build errs seen in #14765