Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: Replaced {{HTMLRefTable}} with markdown table #12017

Merged
merged 25 commits into from
Mar 11, 2023

Conversation

manjuu-eater
Copy link
Contributor

@manjuu-eater manjuu-eater commented Mar 4, 2023

Description

The {{HTMLRefTable}} macro became obsolete, and the entire table content was gone. So, I converted the macros as described below:

  1. Get the markdown corresponding to the "Element" cell of each table from the English version
  2. Set the markdowns to the "Element" cells in the translated version
  3. For each element (=HTML tag), get the first line of the translated version of the page
    (specifically, the first line that is not a front-matter, heading, or Lv1 list)
  4. Set the retrieved line to the "Description" cell
  5. If "Description" cell was empty, fill with en-US description ({{HTMLRefTable}} did not seem to have this process)

I am not entirely sure what the {{HTMLRefTable}} macro was actually doing.
I assumed it probably did something like the above.
A PR in the Japanese version (#11993) was determined that there was no problem.

I can't understand what the translated text means.
So, I would like the reviewer to do the following tasks:

  1. Since I did the conversion semi-mechanically, there may be some strange things in the text. Please check it lightly.
  2. Please compare with WayBackMachine page and check if there are any significant changes.
  3. The chapters that existed in the English version but were not in the translated version (SVG and MathML) have been copied directly from the English version. Please translate them later.

I am writing this English text with using a translator. Sorry if there are parts that are difficult to read.

Thank you in advance.

Motivation

Additional details

WayBackMachine page: http://web.archive.org/web/20221215193922/https://developer.mozilla.org/ko/docs/Web/HTML/Element
current page: https://developer.mozilla.org/ko/docs/Web/HTML/Element

Related issues and pull requests

Relates to #11953

@manjuu-eater manjuu-eater requested a review from a team as a code owner March 4, 2023 21:26
@manjuu-eater manjuu-eater requested review from hochan222 and removed request for a team March 4, 2023 21:26
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Mar 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

Preview URLs

Flaws (50)

URL: /ko/docs/Web/HTML/Element
Title: HTML 요소 참고서
Flaw count: 50

  • macros:
    • /ko/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /ko/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /ko/docs/Web/HTML/Attributes/disabled does not exist but fell back to /en-US/docs/Web/HTML/Attributes/disabled
    • /ko/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /ko/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • and 38 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ko/docs/Web/HTML/Canvas
    • Can't resolve /ko/docs/Learn/HTML/Forms
    • Can't resolve /ko/docs/Learn/HTML/Forms
    • and 1 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)
External URLs (1)

URL: /ko/docs/Web/HTML/Element
Title: HTML 요소 참고서

(comment last updated: 2023-03-11 05:02:23)

@manjuu-eater manjuu-eater changed the title ko: Replaced {{HTMLRefTable}} with a summary of each tag ko: Replaced {{HTMLRefTable}} with markdown table Mar 4, 2023
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manjuu-eater Thank you so much for your contribution. There are a few things to fix, so I only went through half of it first. I will merge the reviews about the translation.

I couldn't add the metadata below, so I'd appreciate it if you could add it! (https://github.com/mdn/translated-content/blob/main/docs/ko/guides/meta-data-guide.md#%ED%8E%98%EC%9D%B4%EC%A7%80-%EA%B0%B1%EC%8B%A0-%ED%91%9C%EC%8B%9C)

---
title: HTML 요소 참고서
slug: Web/HTML/Element
+ l10n:
+  sourceCommit: 65e5a105aa794caa7d339b49951cbaa4a0b83dd3
---

files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
Copy link
Member

@hochan222 hochan222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally, I was planning to update the whole thing, but... I think it would be better to write the meta tag next. It seems like this is enough.

files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
files/ko/web/html/element/index.md Outdated Show resolved Hide resolved
@hochan222
Copy link
Member

Have a nice day :)

@hochan222 hochan222 merged commit b484cd3 into mdn:main Mar 11, 2023
@manjuu-eater manjuu-eater deleted the htmlreftable-ko branch March 16, 2023 07:25
@manjuu-eater
Copy link
Contributor Author

manjuu-eater commented Mar 16, 2023

Thank you for reviewing & editing!

I did not know what sourceCommit meta tag means. (There is no Japanese version of translation documentation...)
Thank you very much!

I made PR which adds sourceCommit to front-matter: #12222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants