Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: macro deprecation: WebRTCSidebar should be removed #10177

Closed
wbamberg opened this issue Nov 25, 2022 · 5 comments
Closed

Chore: macro deprecation: WebRTCSidebar should be removed #10177

wbamberg opened this issue Nov 25, 2022 · 5 comments
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.

Comments

@wbamberg
Copy link
Contributor

I'm currently working on removing custom sidebars from the Web/API docs. There's more context at https://discourse.mozilla.org/t/defaultapisidebar-apiref-and-groupdata/40210/24.

In mdn/content#22486 I removed references to WebRTCSidebar.ejs from en-US content, and in mdn/yari#7674 I'm asking for it to be deprecated.

@wbamberg wbamberg changed the title Chore: macro depreciation: WebRTCSidebar should be removed Chore: macro deprecation: WebRTCSidebar should be removed Nov 25, 2022
@yin1999 yin1999 added l10n-ja Issues related to Japanese content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Nov 26, 2022
@yin1999
Copy link
Member

yin1999 commented Nov 26, 2022

Thanks @wbamberg, I've add labels for all the locales which has used this macro, and created #10191 for remove this from l10n-zh.

@Graywolf9
Copy link
Contributor

Thank you so much @wbamberg !

A little doubt, this is change {{WebRTCSidebar}} by {{DefaultAPISidebar("WebRTC")}}?

@wbamberg
Copy link
Contributor Author

A little doubt, this is change {{WebRTCSidebar}} by {{DefaultAPISidebar("WebRTC")}}?

For pages under /web/api/webrtc_api/ yes. For all other pages, replace {{WebRTCSidebar}} with {{APIRef("WebRTC")}}.

But please feel free to tag me in your PR and I'll have a look :).

@Graywolf9
Copy link
Contributor

Taking care of it in #10326 for es

Thank you @wbamberg !

@yin1999 yin1999 removed the l10n-es Issues related to Spanish content. label Nov 29, 2022
@yin1999 yin1999 removed the l10n-ko Issues related to Korean content. label Dec 10, 2022
@cw118 cw118 added this to the Macros removal milestone Dec 15, 2022
@mfuji09 mfuji09 removed the l10n-ja Issues related to Japanese content. label Feb 5, 2023
@wbamberg
Copy link
Contributor Author

-> mdn/yari#8012 🎉 ! Thanks everyone :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
None yet
Development

No branches or pull requests

5 participants